Skip to content

Commit b693522

Browse files
authored
fix(designer): Prevent deletionConnection occurring on Non-Arm Connections (#8369)
* remove python connector * fix deletion issue
1 parent 17a059e commit b693522

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

  • libs/logic-apps-shared/src/designer-client-services/lib/standard

libs/logic-apps-shared/src/designer-client-services/lib/standard/connection.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,10 @@ export class StandardConnectionService extends BaseConnectionService implements
244244
source: 'connection.ts',
245245
});
246246

247+
const isArmResource = isArmResourceId(connector.id);
248+
247249
try {
248-
const connection = isArmResourceId(connector.id)
250+
const connection = isArmResource
249251
? await this._createConnectionInApiHub(connectionName, connector.id, connectionInfo, shouldTestConnection)
250252
: await this.createConnectionInLocal(connectionName, connector, connectionInfo, parametersMetadata as ConnectionParametersMetadata);
251253

@@ -257,7 +259,9 @@ export class StandardConnectionService extends BaseConnectionService implements
257259
});
258260
return connection;
259261
} catch (error) {
260-
this.deleteConnection(connectionId);
262+
if (isArmResource) {
263+
this.deleteConnection(connectionId);
264+
}
261265
const errorMessage = `Failed to create connection: ${this.tryParseErrorMessage(error)}`;
262266
LoggerService().log({
263267
level: LogEntryLevel.Error,

0 commit comments

Comments
 (0)