Skip to content

Commit 5513aac

Browse files
committed
fix: require alevin-fry >=0.16.1 for the scATAC barcode-tag fix
alevin-fry 0.16.1 (via libradicl 0.14.3) is the first release whose scATAC reader accepts the "b" barcode read-level tag written by the current piscem; 0.16.0 still panics with "atac-reader record context requires a 'barcode' read-level tag" (#204). Raise the minimum in the program-discovery and ATAC-process version checks and in the conda environment. Note: this pins the minimum ahead of alevin-fry 0.16.1 reaching bioconda, so simpleaf-check CI will be red until that build lands.
1 parent 89256cc commit 5513aac

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

simpleaf_conda_env.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ channels:
66
- bioconda
77

88
dependencies:
9-
- alevin-fry>=0.16.0
9+
- alevin-fry>=0.16.1
1010
- piscem>=0.17.1

src/atac/process.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ pub(crate) fn check_progs<P: AsRef<Path>>(
164164

165165
match prog_utils::check_version_constraints(
166166
"alevin-fry",
167-
">=0.16.0, <1.0.0",
167+
">=0.16.1, <1.0.0",
168168
&af_prog_info.version,
169169
) {
170170
Ok(af_ver) => info!("found alevin-fry version {:#}, proceeding", af_ver),

src/utils/prog_utils.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ pub fn get_required_progs_from_paths(
416416

417417
let st = alevin_fry.display().to_string();
418418
let sr = run_fun!(${st} --version);
419-
let v = check_version_constraints_from_output("alevin-fry", ">=0.16.0, <1.0.0", sr)?;
419+
let v = check_version_constraints_from_output("alevin-fry", ">=0.16.1, <1.0.0", sr)?;
420420
rp.alevin_fry = Some(ProgInfo {
421421
exe_path: alevin_fry,
422422
version: format!("{}", v),

0 commit comments

Comments
 (0)