Use explicit std::string&& (rvalue reference) instead of auto&& (forwarding reference)

knoepfel · knoepfel · commit cac6b55f4676 · 2026-06-29T09:06:28.000-05:00
diff --git a/phlex/model/fixed_hierarchy.cpp b/phlex/model/fixed_hierarchy.cpp
@@ -49,7 +49,7 @@ namespace {
     for (auto&& lp : std::move(layer_paths)) {
       auto lp_as_ids =
         lp | std::views::as_rvalue |
-        std::views::transform([](auto&& str) { return identifier(std::move(str)); }) |
+        std::views::transform([](std::string&& str) { return identifier(std::move(str)); }) |
         std::ranges::to<std::vector>();
       result.emplace_back(std::move(lp_as_ids));
     }

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ namespace {`
`49`	`49`	`for (auto&& lp : std::move(layer_paths)) {`
`50`	`50`	`auto lp_as_ids =`
`51`	`51`	`lp \| std::views::as_rvalue \|`
`52`		`- std::views::transform([](auto&& str) { return identifier(std::move(str)); }) \|`
	`52`	`+ std::views::transform([](std::string&& str) { return identifier(std::move(str)); }) \|`
`53`	`53`	`std::ranges::to<std::vector>();`
`54`	`54`	`result.emplace_back(std::move(lp_as_ids));`
`55`	`55`	`}`