StaffMod Module Improvements - Add enabledByDefault#296
Merged
Conversation
…t)` & `StaffModModule#enableAllStaffMods(recipients, enabledByDefault)`
Merged
TrentinTheKid
approved these changes
Jun 25, 2026
ItsNature
added a commit
that referenced
this pull request
Jun 27, 2026
* Add `StaffModModule#enableStaffMods(recipients, mods, enabledByDefault)` & `StaffModModule#enableAllStaffMods(recipients, enabledByDefault)` * Apply changes from optimizations PR
ItsNature
added a commit
that referenced
this pull request
Jul 1, 2026
* Deploy as `1.2.8-SNAPSHOT` * Add `ALLOW_DIG_AND_USE` to Combat Module (#290) * Add CombatModule#ALLOW_ATTACK_AND_USE * Update supported versions docs for the ALLOW_ATTACK_AND_USE option * Rename to `allow-dig-and-use` & add anticheat callout * Update combat.mdx --------- Co-authored-by: Trentin <25537885+TrentinTheKid@users.noreply.github.com> * Add `ServerlinkModule#LEGACY_BUTTON_PLACEMENT` & `ServerLinkModule#MODERN_BUTTON_PLACEMENT` (#291) * Optimizations (#294) * Optimize `EventBus#post` * Optimize packet broadcasting * Optimize `Option#getKey` * Optimize `ApolloWorld#getPlayers` * Optimize `NetworkOptions#sendOption` * Avoid streams in packet/recipient conversions * Remove dead repo * Add `CombatModule#DISABLE_BLOCK_MISS_PENALTY` (#297) * StaffMod Module Improvements - Add `enabledByDefault` (#296) * Add `StaffModModule#enableStaffMods(recipients, mods, enabledByDefault)` & `StaffModModule#enableAllStaffMods(recipients, enabledByDefault)` * Apply changes from optimizations PR * Feature - Markers Module (#293) * Add Marker API classes * Marker Module Impl * Add examples and docs # Conflicts: # example/bukkit/json/src/main/java/com/lunarclient/apollo/example/json/util/JsonPacketUtil.java # example/bukkit/proto/src/main/java/com/lunarclient/apollo/example/proto/util/ProtobufPacketUtil.java * Rename loot chest example to display block example * Publish branch * add marker overview gif * add overview gif to marker docs * Relocate compact mode callout * Remove dead repo * Update markers gif * Use apollo-protos 0.2.0 * Apply changes from optimizations PR * Remove temp publish --------- Co-authored-by: Trentin <25537885+TrentinTheKid@users.noreply.github.com> * Sync LunarClient Mods & Options (#298) * Sync LunarClient Mods & Options * Update version tags to 1.2.8 --------- Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com> * Bump to 1.2.8 (#299) --------- Co-authored-by: Trentin <25537885+TrentinTheKid@users.noreply.github.com> Co-authored-by: LunarClient Bot <lc-bot@moonsworth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Description:
Adds an
enabledByDefaultparameter to the Staff Mod Module's enable methods so servers can choose whether granting a staff mod also activates it on the player's client.Changes:
StaffModModule:StaffModModule#enableStaffMods(Recipients, List<StaffMod>, boolean enabledByDefault)StaffModModule#enableAllStaffMods(Recipients, boolean enabledByDefault)enabledByDefaultset asfalse.Code Example:
Review Request Checklist
feature/add-module&bugfix/fix-issue)