Skip to content

CLI: Deploy through v1 API with v2 spec#1465

Open
josephjclark wants to merge 4 commits into
mainfrom
deploy-v1-with-v2-spec
Open

CLI: Deploy through v1 API with v2 spec#1465
josephjclark wants to merge 4 commits into
mainfrom
deploy-v1-with-v2-spec

Conversation

@josephjclark

@josephjclark josephjclark commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Short Description

Fixes #1464

QA Notes

I have run the following manual tests

  • Can deploy a v1 spec to lightning on main
  • Can deploy a v1 spec to lightning on portability branch
  • Can deploy a v2 spec to lightning on portability branch

All for new projects and with the v1 command

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@josephjclark josephjclark marked this pull request as ready for review June 25, 2026 10:35
@github-project-automation github-project-automation Bot moved this to New Issues in Core Jun 25, 2026

@brandonjackson brandonjackson left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@josephjclark

josephjclark commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator Author

Ok, hit a problem which will need to be properly reflected in unit and integration tests. Because these should not be passing.

When converting the v2 project down to a v1 spec, we MUST exclude UUIDs. The Project converter will add them somewhere down the line but this invalidates assumptions in the v1 sync.

This should have been caught in a integration test: I'm going to add some validation to the mock API. So the plan is:

  1. Update lightning mock
  2. Integration test should fail
  3. Export a v2 project without UUIDs
  4. Add the no-uuid flag to the CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

Enable deploy v1 to deploy a v2 spec file

3 participants