Refactor plugin loading LINQ to fluent chain

emako · emako · commit 3b1bbe9e3218 · 2026-06-23T14:08:23.000+08:00
diff --git a/QuickLook/PluginManager.cs b/QuickLook/PluginManager.cs
@@ -92,11 +92,12 @@ private void LoadPlugins(string folder)
             {
                 try
                 {
-                    (from t in Assembly.LoadFrom(lib).GetExportedTypes()
-                     where !t.IsInterface && !t.IsAbstract
-                     where typeof(IViewer).IsAssignableFrom(t)
-                     select t).ToList()
-                    .ForEach(type => LoadedPlugins.Add(type.CreateInstance<IViewer>()));
+                    Assembly.LoadFrom(lib)
+                        .GetExportedTypes()
+                        .Where(t => !t.IsInterface && !t.IsAbstract
+                            && typeof(IViewer).IsAssignableFrom(t))
+                        .ToArray()
+                        .ForEach(t => LoadedPlugins.Add(t.CreateInstance<IViewer>()));
                 }
                 // 0x80131515: ERROR_ASSEMBLY_FILE_BLOCKED - Windows blocked the assembly due to security policy
                 catch (FileLoadException ex) when (ex.HResult == unchecked((int)0x80131515) && SettingHelper.IsPortableVersion())

Original file line number	Diff line number	Diff line change
`@@ -92,11 +92,12 @@ private void LoadPlugins(string folder)`
`92`	`92`	`{`
`93`	`93`	`try`
`94`	`94`	`{`
`95`		`- (from t in Assembly.LoadFrom(lib).GetExportedTypes()`
`96`		`- where !t.IsInterface && !t.IsAbstract`
`97`		`- where typeof(IViewer).IsAssignableFrom(t)`
`98`		`- select t).ToList()`
`99`		`- .ForEach(type => LoadedPlugins.Add(type.CreateInstance<IViewer>()));`
	`95`	`+ Assembly.LoadFrom(lib)`
	`96`	`+ .GetExportedTypes()`
	`97`	`+ .Where(t => !t.IsInterface && !t.IsAbstract`
	`98`	`+ && typeof(IViewer).IsAssignableFrom(t))`
	`99`	`+ .ToArray()`
	`100`	`+ .ForEach(t => LoadedPlugins.Add(t.CreateInstance<IViewer>()));`
`100`	`101`	`}`
`101`	`102`	`// 0x80131515: ERROR_ASSEMBLY_FILE_BLOCKED - Windows blocked the assembly due to security policy`
`102`	`103`	`catch (FileLoadException ex) when (ex.HResult == unchecked((int)0x80131515) && SettingHelper.IsPortableVersion())`