Fix Issue #4746 by changing encoding of tempfile's to use locale.getpreferredencoding(False) instead of hardcoded utf-8

Author: bdbaddog

CHANGES.txt

@@ -82,6 +82,11 @@ RELEASE  VERSION/DATE TO BE FILLED IN LATER
       windows-2022. The packaging tar bz2 and xz tests should be run on
       Windows 11 and GitHub windows-2025.
 
+  From William Deegan:
+    - Fix Issue #4746. TEMPFILE's are written with utf-8 encoding, this doesn't work
+      for all situations. Change to use locale.getpreferredencoding(False), which should
+      yield the encoding for the system.
+
   From Edward Peek:
     - Fix the variant dir component being missing from generated source file
       paths with CompilationDatabase() builder (Fixes #4003).

RELEASE.txt

@@ -76,6 +76,10 @@ FIXES
 - Fix a test problem on Windows where UNC tests failed due to incorrect path
   munging if a non-default %TEMP% was defined (as in moving to a Dev Drive).
 
+- Fix Issue #4746. TEMPFILE's are written with utf-8 encoding, this doesn't work
+  for all situations. Change to use locale.getpreferredencoding(False), which should
+  yield the encoding for the system.
+
 IMPROVEMENTS
 ------------
 

SCons/Platform/__init__.py

@@ -47,6 +47,7 @@
 import os
 import sys
 import tempfile
+import locale
 
 import SCons.Errors
 import SCons.Subst
@@ -279,7 +280,7 @@ def tmpfile_cleanup(file) -> None:
         tempfile_esc_func = env.get('TEMPFILEARGESCFUNC', SCons.Subst.quote_spaces)
         args = [tempfile_esc_func(arg) for arg in cmd[1:]]
         join_char = env.get('TEMPFILEARGJOIN', ' ')
-        os.write(fd, bytearray(join_char.join(args) + "\n", encoding="utf-8"))
+        os.write(fd, bytearray(join_char.join(args) + "\n", encoding=locale.getpreferredencoding(False)))
         os.close(fd)
 
         # XXX Using the SCons.Action.print_actions value directly