Update AppendUnique, PrependUnique unit tests - #4742
Merged
Conversation
Nitpicking: test the (probably rate) situation where the existing value contained more than one instance of the value being appended. Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann
added
the
testsuite
3 tasks
bdbaddog
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nitpicking: test the (probably rare) situation where the existing value contained more than one instance of the value being added. This should enshrine the behavior that adding without
delete_existingleaves the existing alone (including dupes), while withdelete_existingall existing instances of the value being added are removed.No SCons or doc impacts, test only.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).