Commit 5a74b0f
authored
fix(local-dev): drop sbt build knobs that ship an unrunnable dist (apache#6097)
### What changes were proposed in this PR?
`build_all` in `bin/local-dev/main.sh` passed three CLI-only sbt knobs
that each made `sbt <svc>/dist` produce a dist that packaged and
reported success but could not run. This PR removes all three and keeps
only the heap/GC flags.
- `-Dsbt.pipelining=true`: inter-project dependencies are consumed as
early-output signature jars, so the dist drops the real
`dao`/`auth`/`config`/`resource` jars from `lib/` and every service dies
at startup with `NoClassDefFoundError` on a sibling-module class (e.g.
`org/apache/texera/dao/SqlServer$`).
- `set every (Compile / doc / sources) := Seq.empty`: `set every`
ignores the written scope and zeroes the shared `sources` key in every
scope, including `Compile / sources`, so nothing compiles, no main class
is discovered, and no `bin/<service>` launcher is generated.
- `set every (Compile / packageDoc / publishArtifact) := false`: the
same `set every` trap turns off `publishArtifact` for the main jar
artifacts too, so the inter-project dependency jars drop out of the
dist.
The regression tests in `test_local_dev_sh.sh` are flipped to guards
that fail if any of these knobs is reintroduced. Skipping scaladoc has
to be done per-project in `build.sbt`, not with a global `set every`, so
it is left out until it can be done safely.
### Any related issues, documentation, discussions?
Closes apache#6096
### How was this PR tested?
Verified a clean multi-project dist bundles the
`dao`/`auth`/`config`/`resource` jars and a working `bin/<service>`
launcher, and that `bin/local-dev/tests/test_local_dev_sh.sh` passes.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)1 parent bc5accf commit 5a74b0f
2 files changed
Lines changed: 36 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1916 | 1916 | | |
1917 | 1917 | | |
1918 | 1918 | | |
1919 | | - | |
1920 | | - | |
| 1919 | + | |
| 1920 | + | |
| 1921 | + | |
| 1922 | + | |
| 1923 | + | |
| 1924 | + | |
| 1925 | + | |
| 1926 | + | |
| 1927 | + | |
| 1928 | + | |
| 1929 | + | |
| 1930 | + | |
| 1931 | + | |
| 1932 | + | |
| 1933 | + | |
| 1934 | + | |
| 1935 | + | |
| 1936 | + | |
1921 | 1937 | | |
1922 | 1938 | | |
1923 | 1939 | | |
1924 | 1940 | | |
1925 | | - | |
1926 | | - | |
1927 | | - | |
1928 | 1941 | | |
1929 | 1942 | | |
1930 | 1943 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
413 | 413 | | |
414 | 414 | | |
415 | 415 | | |
416 | | - | |
417 | | - | |
418 | | - | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
419 | 422 | | |
420 | 423 | | |
421 | | - | |
422 | | - | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
423 | 427 | | |
424 | | - | |
| 428 | + | |
425 | 429 | | |
426 | | - | |
427 | | - | |
| 430 | + | |
| 431 | + | |
428 | 432 | | |
429 | | - | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
430 | 439 | | |
431 | 440 | | |
432 | 441 | | |
| |||
0 commit comments