Skip to content

FINERACT-2455: Working Capital loan details with start dates#5998

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2455/working-capital-loan-details-with-start-dates
Jun 22, 2026
Merged

FINERACT-2455: Working Capital loan details with start dates#5998
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2455/working-capital-loan-details-with-start-dates

Conversation

@alberto-art3ch

@alberto-art3ch alberto-art3ch commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description

We are adding two new fields to Working Capital Loan details API

  • Delinquency start date (if applicable)
  • Breach start date (if applicable)

Both of them calculated the same way, start date plus grace days (if applicable)

FINERACT-2455

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch from 7911cbd to a34091f Compare June 18, 2026 02:20
@adamsaghy

adamsaghy commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@alberto-art3ch Please rebase.

@ruzeynalov ruzeynalov force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch 3 times, most recently from 31f2a28 to 035e0b7 Compare June 18, 2026 13:21
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch 2 times, most recently from 4183b98 to ad682b1 Compare June 19, 2026 01:14
@ruzeynalov ruzeynalov force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch from ad682b1 to 8813e35 Compare June 19, 2026 15:04
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch from 8813e35 to edf1733 Compare June 19, 2026 16:05
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch from edf1733 to c8c5673 Compare June 22, 2026 12:57
@ruzeynalov ruzeynalov force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch from c8c5673 to 3c64e04 Compare June 22, 2026 13:04
@adamsaghy

adamsaghy commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@alberto-art3ch
What went wrong:
Execution failed for task ':fineract-e2e-tests-core:spotlessJavaCheck'.

The following files had format violations:
src/test/java/org/apache/fineract/test/stepdef/loan/WorkingCapitalLoanAccountStepDef.java
@@ -2016,9 +2016,9 @@
····················actualValues.add(response.getBalance()·==·null·||·response.getBalance().getTotalDiscountFee()·==·null·?·null
····························:·new·Utils.DoubleFormatter(response.getBalance().getTotalDiscountFee().doubleValue()).format());
················case·"breachStartDate"·->
-························actualValues.add(response.getBreachStartDate()·==·null·?·"null"·:·response.getBreachStartDate().toString());
+····················actualValues.add(response.getBreachStartDate()·==·null·?·"null"·:·response.getBreachStartDate().toString());
················case·"delinquencyStartDate"·->
-························actualValues.add(response.getDelinquencyStartDate()·==·null·?·"null"·:·response.getDelinquencyStartDate().toString());
+····················actualValues.add(response.getDelinquencyStartDate()·==·null·?·"null"·:·response.getDelinquencyStartDate().toString());
················case·"totalDiscountFeeAdjustment"·->
····················actualValues.add(response.getBalance()·==·null·||·response.getBalance().getTotalDiscountFeeAdjustment()·==·null·?·null
····························:·new·Utils.DoubleFormatter(response.getBalance().getTotalDiscountFeeAdjustment().doubleValue()).format());
[Incubating] Problems report is available at: file:///home/runner/work/fineract/fineract/build/reports/problems/problems-report.html
Run './gradlew :fineract-e2e-tests-core:spotlessApply' to fix these violations.

@ruzeynalov ruzeynalov force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch from 3c64e04 to 3fa6480 Compare June 22, 2026 13:54
@ruzeynalov ruzeynalov force-pushed the FINERACT-2455/working-capital-loan-details-with-start-dates branch from 3fa6480 to 036d297 Compare June 22, 2026 14:37
@adamsaghy adamsaghy merged commit 28f790a into apache:develop Jun 22, 2026
90 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2455/working-capital-loan-details-with-start-dates branch June 22, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galovics galovics galovics approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alberto-art3ch @adamsaghy @galovics