Skip to content

Commit d45a9f5

Browse files
jbroadushatstand
authored andcommitted
Enable debug logging for GstEnginePipeline by default.
Use qLogCat to put verbose GStreamer callback messages into a new GstEnginePipelineCallbacks category. Filter that category instead of the entire class by default.
1 parent 66f354f commit d45a9f5

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

ext/libclementine-common/core/logging.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ static Level sDefaultLevel = Level_Debug;
4242
static QMap<QString, Level>* sClassLevels = nullptr;
4343
static QIODevice* sNullDevice = nullptr;
4444

45-
const char* kDefaultLogLevels = "GstEnginePipeline:2,*:3";
45+
const char* kDefaultLogLevels = "GstEnginePipelineCallbacks:2,*:3";
4646

4747
static const char* kMessageHandlerMagic = "__logging_message__";
4848
static const int kMessageHandlerMagicLength = strlen(kMessageHandlerMagic);

src/engines/gstenginepipeline.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,8 @@ gboolean GstEnginePipeline::BusCallback(GstBus*, GstMessage* msg,
549549
gpointer self) {
550550
GstEnginePipeline* instance = reinterpret_cast<GstEnginePipeline*>(self);
551551

552-
qLog(Debug) << instance->id() << "bus message" << GST_MESSAGE_TYPE_NAME(msg);
552+
qLogCat(Debug, "GstEnginePipelineCallbacks")
553+
<< instance->id() << "bus message" << GST_MESSAGE_TYPE_NAME(msg);
553554

554555
switch (GST_MESSAGE_TYPE(msg)) {
555556
case GST_MESSAGE_ERROR:
@@ -575,8 +576,8 @@ GstBusSyncReply GstEnginePipeline::BusCallbackSync(GstBus*, GstMessage* msg,
575576
gpointer self) {
576577
GstEnginePipeline* instance = reinterpret_cast<GstEnginePipeline*>(self);
577578

578-
qLog(Debug) << instance->id() << "sync bus message"
579-
<< GST_MESSAGE_TYPE_NAME(msg);
579+
qLogCat(Debug, "GstEnginePipelineCallbacks")
580+
<< instance->id() << "sync bus message" << GST_MESSAGE_TYPE_NAME(msg);
580581

581582
switch (GST_MESSAGE_TYPE(msg)) {
582583
case GST_MESSAGE_EOS:
@@ -959,7 +960,8 @@ GstPadProbeReturn GstEnginePipeline::EventHandoffCallback(GstPad*,
959960
GstEnginePipeline* instance = reinterpret_cast<GstEnginePipeline*>(self);
960961
GstEvent* e = gst_pad_probe_info_get_event(info);
961962

962-
qLog(Debug) << instance->id() << "event" << GST_EVENT_TYPE_NAME(e);
963+
qLogCat(Debug, "GstEnginePipelineCallbacks")
964+
<< instance->id() << "event" << GST_EVENT_TYPE_NAME(e);
963965

964966
switch (GST_EVENT_TYPE(e)) {
965967
case GST_EVENT_SEGMENT:

0 commit comments

Comments
 (0)