fix: discard invalid component pro: map instead of passing it through

CodeRabbit review (PR #2883, discussion_r3729413928): extractComponentSections
assigned result.ComponentPro before schema.DecodeComponentPro validated it, so
a typo'd pro: {enable: false} (meant "enabled") still flowed downstream as the
raw map. pro.ResolveSection ignores unrecognized keys, so the typo silently
resolved to Pro's default-enabled behavior -- the opposite of what the user
wrote. Now the raw map is only assigned after decoding succeeds; the warning
stays non-fatal so sibling components still process. Updated
TestProcessStackConfig_ProSectionUnknownKeyDoesNotBlockProcessing to assert
the pro: section is absent (not silently enabling Pro) rather than passed
through unchanged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: osterman

internal/exec/stack_processor_process_stacks_helpers_extraction.go

@@ -64,15 +64,19 @@ func extractComponentSections(opts *ComponentProcessorOptions, result *Component
 			log.Warn("component 'pro' section must be a map, ignoring it",
 				"error", fmt.Errorf("%w: 'components.%s.%s.pro' in the file '%s'", errUtils.ErrInvalidComponentPro, opts.ComponentType, opts.Component, opts.StackName))
 		} else {
-			result.ComponentPro = componentPro
-			// Strict-decode as a validation-only side channel: catches an unrecognized key
-			// (e.g. "enable" instead of "enabled") the same way `atmos validate stacks`
-			// would via JSON Schema, without requiring that separate command to have been
-			// run first. Non-fatal for the same reason as the type check above -- ComponentPro
-			// stays the raw map either way, so downstream resolution is unaffected.
+			// Strict-decode before assigning: catches an unrecognized key (e.g. "enable"
+			// instead of "enabled") the same way `atmos validate stacks` would via JSON
+			// Schema, without requiring that separate command to have been run first.
+			// Discarding the raw map on failure (rather than assigning it anyway) matters --
+			// downstream resolution ignores unknown keys, so a `pro: {enable: false}` typo
+			// would otherwise silently fall through to Pro's enabled-by-default behavior,
+			// the opposite of what the user wrote. Non-fatal for the same reason as the type
+			// check above: one component's typo must not abort sibling components.
 			if _, err := schema.DecodeComponentPro(componentPro); err != nil {
 				log.Warn("component 'pro' section has an unrecognized field, check for a typo (e.g. 'enable' instead of 'enabled')",
 					"component", opts.Component, "type", opts.ComponentType, "file", opts.StackName, "error", err)
+			} else {
+				result.ComponentPro = componentPro
 			}
 		}
 	}

internal/exec/stack_processor_process_stacks_test.go

@@ -1635,10 +1635,11 @@ func TestProcessStackConfig_MalformedComponentProDoesNotBlockSiblings(t *testing
 
 // TestProcessStackConfig_ProSectionUnknownKeyDoesNotBlockProcessing guards against a typo'd
 // pro: key (e.g. "enable" instead of "enabled") having any fatal effect. schema.DecodeComponentPro
-// rejects the unknown key so a warning gets logged (see extractComponentSections), but that must
-// stay a warning, not an error -- and the raw pro: map must still pass through unchanged so
-// pro.ResolveSection's existing default-enabled-unless-explicit-false behavior is unaffected by
-// this validation-only side channel.
+// rejects the unknown key so a warning gets logged (see extractComponentSections), and that must
+// stay a warning, not an error. But the invalid raw map must also be discarded rather than passed
+// through: pro.ResolveSection ignores unrecognized keys, so a passed-through `{enable: false}`
+// would silently resolve to Pro's default-enabled behavior -- the opposite of the user's evident
+// intent to disable it.
 func TestProcessStackConfig_ProSectionUnknownKeyDoesNotBlockProcessing(t *testing.T) {
 	atmosConfig := &schema.AtmosConfiguration{}
 
@@ -1680,9 +1681,8 @@ func TestProcessStackConfig_ProSectionUnknownKeyDoesNotBlockProcessing(t *testin
 	require.True(t, ok, "terraform components should be present")
 	typo, ok := terraformSection["typo"].(map[string]any)
 	require.True(t, ok, "typo component should still resolve")
-	proSection, ok := typo[cfg.ProSectionName].(map[string]any)
-	require.True(t, ok, "raw pro: map must still pass through despite the unrecognized key")
-	assert.Equal(t, map[string]any{"enable": false}, proSection, "the strict decode is validation-only and must not mutate or strip the raw section")
+	_, hasPro := typo[cfg.ProSectionName]
+	assert.False(t, hasPro, "an invalid pro: map must be discarded, not passed through as if it enabled Pro by default")
 }
 
 // componentHooks extracts the merged hooks section for a terraform component