Commit ca28926
fix(emulator): CI-proof the local-gitops commit identity and kubeconfig retry
Two CI failures on the local-gitops / native-emulator work:
- [floci] go e2e: TestLocalGitOpsPushE2E failed with `git commit (exit 128)` —
the CI runner has no global git identity, and the deployments repo did not pin
one, so the provisioner's commit hit "Please tell me who you are". Pin
`commit.author` on the example's deployments repo (the schema documents this as
required in CI) and make the E2E run with GIT_CONFIG_GLOBAL/SYSTEM=os.DevNull so
it reproduces the no-ambient-identity runner and self-validates the fix.
- [Acceptance/windows]: TestManager_Resolve_KubernetesKubeconfigError flaked —
with kubeconfigReadyTimeout=0 the harvest retry used `time.Now().After(deadline)`
(strict >). On Windows's coarse monotonic clock the first post-attempt read can
equal the deadline, so it polled again (an extra List call) and tripped the
mock's Times(2). Use reached-or-passed semantics (`!time.Now().Before(deadline)`)
so a zero timeout makes exactly one attempt on every platform.
Validated on Podman: push E2E passes with no ambient git identity; emulator unit
tests (incl. the kubeconfig test) pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 407fee6 commit ca28926
3 files changed
Lines changed: 18 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
24 | 31 | | |
25 | 32 | | |
26 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
54 | 58 | | |
55 | 59 | | |
56 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
38 | 42 | | |
39 | 43 | | |
40 | 44 | | |
| |||
0 commit comments