Skip to content

Commit 3f6c3bd

Browse files
committed
Address MAUI sample review feedback
1 parent b43a40d commit 3f6c3bd

3 files changed

Lines changed: 24 additions & 12 deletions

File tree

samples/Exceptionless.SampleMaui/MauiProgram.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ private static ExceptionlessClient CreateExceptionlessClient() {
3535
config.DefaultData["Platform"] = DeviceInfo.Current.Platform.ToString();
3636
config.DefaultData["DeviceIdiom"] = DeviceInfo.Current.Idiom.ToString();
3737
config.SetVersion(AppInfo.Current.VersionString);
38-
config.UseFolderStorage(Path.Combine(appDataDirectory, "exceptionless-queue"));
39-
config.UseFileLogger(Path.Combine(appDataDirectory, "exceptionless-client.log"), LogLevel.Info);
38+
config.UseFolderStorage(Path.Join(appDataDirectory, "exceptionless-queue"));
39+
config.UseFileLogger(Path.Join(appDataDirectory, "exceptionless-client.log"), LogLevel.Info);
4040
});
4141

4242
client.Startup();

samples/Exceptionless.SampleMaui/SampleDogfoodRunner.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ public async Task RunIfRequestedAsync() {
1717
await _sampleEvents.RefreshProjectConfigurationAsync();
1818
string configValue = _sampleEvents.GetSampleConfigValue();
1919
string exceptionReferenceId = _sampleEvents.SubmitHandledException();
20-
string? logReferenceId = _sampleEvents.SubmitWarningLog();
21-
string? featureReferenceId = _sampleEvents.TrackFeatureUsage();
20+
string logReferenceId = _sampleEvents.SubmitWarningLog();
21+
string featureReferenceId = _sampleEvents.TrackFeatureUsage();
2222
await _sampleEvents.FlushQueueAsync();
2323

2424
WriteResult(resultPath,
@@ -41,8 +41,10 @@ private static void WriteResult(string? path, params string[] lines) {
4141
// Autorun should still exercise the client if a platform sandbox rejects the result path.
4242
try {
4343
File.WriteAllLines(path, lines);
44-
} catch (IOException) {
45-
} catch (UnauthorizedAccessException) {
44+
} catch (IOException ex) {
45+
System.Diagnostics.Debug.WriteLine($"Unable to write Exceptionless MAUI sample dogfood result: {ex}");
46+
} catch (UnauthorizedAccessException ex) {
47+
System.Diagnostics.Debug.WriteLine($"Unable to write Exceptionless MAUI sample dogfood result: {ex}");
4648
}
4749
}
4850
}

samples/Exceptionless.SampleMaui/SampleEventService.cs

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,24 @@ public string SubmitHandledException() {
2828
return referenceId;
2929
}
3030

31-
public string? SubmitWarningLog() {
32-
_exceptionlessClient.SubmitLog("Exceptionless.SampleMaui.MainPage", "MAUI sample warning log.", LogLevel.Warn);
33-
return _exceptionlessClient.GetLastReferenceId();
31+
public string SubmitWarningLog() {
32+
string referenceId = Guid.NewGuid().ToString("N");
33+
34+
_exceptionlessClient.CreateLog("Exceptionless.SampleMaui.MainPage", "MAUI sample warning log.", LogLevel.Warn)
35+
.SetReferenceId(referenceId)
36+
.Submit();
37+
38+
return referenceId;
3439
}
3540

36-
public string? TrackFeatureUsage() {
37-
_exceptionlessClient.SubmitFeatureUsage("MauiSample.TrackFeature");
38-
return _exceptionlessClient.GetLastReferenceId();
41+
public string TrackFeatureUsage() {
42+
string referenceId = Guid.NewGuid().ToString("N");
43+
44+
_exceptionlessClient.CreateFeatureUsage("MauiSample.TrackFeature")
45+
.SetReferenceId(referenceId)
46+
.Submit();
47+
48+
return referenceId;
3949
}
4050

4151
public async Task RefreshProjectConfigurationAsync() {

0 commit comments

Comments
 (0)