Skip to content

Commit 3e50a8c

Browse files
authored
Merge pull request #184 from mattn/fix/admin-body-leak
admin: close the response body and don't use it as a format string
2 parents 1cb730f + c525a25 commit 3e50a8c

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

admin.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ var admin = &cli.Command{
132132
continue
133133
}
134134
b, err := io.ReadAll(resp.Body)
135+
resp.Body.Close()
135136
if err != nil {
136137
log("failed to read response: %s\n", err)
137138
continue
@@ -142,7 +143,7 @@ var admin = &cli.Command{
142143
if len(bodyPrintable) > 300 {
143144
bodyPrintable = bodyPrintable[0:297] + "..."
144145
}
145-
log(bodyPrintable)
146+
log("%s", bodyPrintable)
146147
continue
147148
}
148149
var response nip86.Response
@@ -152,10 +153,9 @@ var admin = &cli.Command{
152153
if len(bodyPrintable) > 300 {
153154
bodyPrintable = bodyPrintable[0:297] + "..."
154155
}
155-
log(bodyPrintable)
156+
log("%s", bodyPrintable)
156157
continue
157158
}
158-
resp.Body.Close()
159159

160160
// print the result
161161
log("\n")

0 commit comments

Comments
 (0)