fix(bunker): avoid duplicate subscriptions for custom relays

Author: aaccioly

bunker.go

@@ -390,18 +390,31 @@ var bunker = &cli.Command{
 				return
 			}
 
-			go func() {
-				for event := range sys.Pool.SubscribeMany(ctx, relays, nostr.Filter{
-					Kinds:     []nostr.Kind{nostr.KindNostrConnect},
-					Tags:      nostr.TagMap{"p": []string{pubkey.Hex()}},
-					Since:     nostr.Now(),
-					LimitZero: true,
-				}, nostr.SubscriptionOptions{Label: "nak-bunker"}) {
-					events <- event
+			// compute new custom relays to avoid duplicate subscriptions
+			newCustomRelays := make([]string, 0, len(relays))
+			for _, r := range relays {
+				if !slices.Contains(allRelays, r) {
+					newCustomRelays = append(newCustomRelays, r)
+					allRelays = append(allRelays, r)
 				}
-			}()
+			}
+
+			if len(newCustomRelays) > 0 {
+				log("subscribing to %d new relays: %s\n", len(newCustomRelays), strings.Join(newCustomRelays, ","))
+				go func() {
+					for event := range sys.Pool.SubscribeMany(ctx, relays, nostr.Filter{
+						Kinds:     []nostr.Kind{nostr.KindNostrConnect},
+						Tags:      nostr.TagMap{"p": []string{pubkey.Hex()}},
+						Since:     nostr.Now(),
+						LimitZero: true,
+					}, nostr.SubscriptionOptions{Label: "nak-bunker"}) {
+						events <- event
+					}
+				}()
+
+				time.Sleep(time.Millisecond * 25)
+			}
 
-			time.Sleep(time.Millisecond * 25)
 			jresp, _ := json.MarshalIndent(resp, "", "  ")
 			log("~ responding with %s\n", string(jresp))
 			for res := range sys.Pool.PublishMany(ctx, relays, eventResponse) {