Skip to content

There are many untyped globals in the codebase #2

Description

@guilhermebodin

First of all, thank you very much for developing an official API. I haven`t tested the code yet, nor have I made any benchmarks. My comment has the single goal of trying to help the developers to have the best API possible.

Looking around the codebase, I found many untyped global variables. Maybe these variables should be declared as const and used throughout the module. There is a performance tip on the Julia documentation to avoid this pattern https://docs.julialang.org/en/v1/manual/performance-tips/#Avoid-untyped-global-variables.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions