test: 96% line coverage, 305 tests — reduce branches, tree root, LRU, migration verification

Author: TheCryptoDonkey

README.md

@@ -4,7 +4,7 @@
 
 [![CI](https://github.com/forgesworn/bray/actions/workflows/ci.yml/badge.svg)](https://github.com/forgesworn/bray/actions/workflows/ci.yml)
 [![npm](https://img.shields.io/npm/v/nostr-bray)](https://www.npmjs.com/package/nostr-bray)
-[![coverage](https://img.shields.io/badge/coverage-94%25-brightgreen)](./package.json)
+[![coverage](https://img.shields.io/badge/coverage-96%25-brightgreen)](./package.json)
 [![licence](https://img.shields.io/npm/l/nostr-bray)](./LICENSE)
 [![TypeScript](https://img.shields.io/badge/TypeScript-ESM-blue)](./tsconfig.json)
 

test/context.test.ts

@@ -191,4 +191,35 @@ describe('IdentityContext', () => {
       expect(refB!.every(b => b === 0)).toBe(true)
     })
   })
+
+  describe('treeRootPubkey', () => {
+    it('returns the nsec-tree root master pubkey', () => {
+      const ctx = new IdentityContext(TEST_NSEC, 'nsec')
+      expect(ctx.treeRootPubkey).toBeDefined()
+      // Tree root pubkey is different from the raw key's npub
+      expect(ctx.treeRootPubkey).not.toBe(ctx.activeNpub)
+      ctx.destroy()
+    })
+  })
+
+  describe('LRU cache duplicate', () => {
+    it('re-deriving the same identity updates cache without duplicating', () => {
+      const ctx = new IdentityContext(TEST_NSEC, 'nsec')
+      const first = ctx.derive('same', 0)
+      const second = ctx.derive('same', 0)
+      expect(first.npub).toBe(second.npub)
+      const list = ctx.listIdentities()
+      const sameCount = list.filter(i => i.purpose === 'same').length
+      expect(sameCount).toBe(1)
+      ctx.destroy()
+    })
+  })
+
+  describe('activePublicKeyHex', () => {
+    it('returns 64-char hex public key', () => {
+      const ctx = new IdentityContext(TEST_NSEC, 'nsec')
+      expect(ctx.activePublicKeyHex).toMatch(/^[0-9a-f]{64}$/)
+      ctx.destroy()
+    })
+  })
 })

test/identity/migration.test.ts

@@ -104,6 +104,18 @@ describe('identity migration', () => {
       }
     })
 
+    it('skips events that fail signature verification', async () => {
+      const pool = mockPool()
+      const badEvent = { ...mockProfile, pubkey: 'wrong-pubkey' } // author mismatch
+      const backup = {
+        pubkeyHex: 'oldpub123',
+        events: [badEvent, mockContacts],
+      }
+      const result = await handleIdentityRestore(ctx, pool as any, backup)
+      expect(result.skipped.length).toBe(1)
+      expect(result.skipped[0].reason).toMatch(/verification|mismatch/i)
+    })
+
     it('does NOT re-sign kind 31000 attestations (trust chain protection)', async () => {
       const pool = mockPool()
       const backup = {

test/social/groups.test.ts

@@ -36,6 +36,16 @@ describe('NIP-29 group handlers', () => {
       expect(result.isOpen).toBe(true)
     })
 
+    it('takes highest created_at from multiple metadata events', async () => {
+      const events = [
+        { kind: 39000, pubkey: 'r', created_at: 500, tags: [['d', 'g'], ['name', 'Old']], content: '', id: '1', sig: 's' },
+        { kind: 39000, pubkey: 'r', created_at: 1000, tags: [['d', 'g'], ['name', 'New']], content: '', id: '2', sig: 's' },
+      ]
+      const pool = mockPool(events)
+      const result = await handleGroupInfo(pool as any, 'npub1test', { relay: 'wss://test', groupId: 'g' })
+      expect(result.name).toBe('New')
+    })
+
     it('returns minimal info when no metadata found', async () => {
       const pool = mockPool([])
       const result = await handleGroupInfo(pool as any, 'npub1test', { relay: 'wss://test', groupId: 'unknown' })
@@ -100,6 +110,17 @@ describe('NIP-29 group handlers', () => {
       expect(result[1].role).toBe('admin')
     })
 
+    it('takes highest created_at from multiple member events', async () => {
+      const events = [
+        { kind: 39002, pubkey: 'r', created_at: 500, tags: [['d', 'g'], ['p', 'old']], content: '', id: '1', sig: 's' },
+        { kind: 39002, pubkey: 'r', created_at: 1000, tags: [['d', 'g'], ['p', 'new']], content: '', id: '2', sig: 's' },
+      ]
+      const pool = mockPool(events)
+      const result = await handleGroupMembers(pool as any, 'npub1test', { groupId: 'g' })
+      expect(result.length).toBe(1)
+      expect(result[0].pubkey).toBe('new')
+    })
+
     it('returns empty when no member list found', async () => {
       const pool = mockPool([])
       const result = await handleGroupMembers(pool as any, 'npub1test', { groupId: 'empty' })

test/social/handlers.test.ts

@@ -94,6 +94,15 @@ describe('social handlers', () => {
       expect(result.about).toBe('A test user')
     })
 
+    it('takes highest created_at when multiple profiles returned', async () => {
+      const pool = mockPool([
+        { kind: 0, pubkey: 'p', created_at: 500, tags: [], content: JSON.stringify({ name: 'Old' }), id: '1', sig: 's' },
+        { kind: 0, pubkey: 'p', created_at: 1000, tags: [], content: JSON.stringify({ name: 'New' }), id: '2', sig: 's' },
+      ])
+      const result = await handleSocialProfileGet(pool as any, 'npub', 'p')
+      expect(result.name).toBe('New')
+    })
+
     it('returns empty profile when none found', async () => {
       const pool = mockPool([])
       const result = await handleSocialProfileGet(pool as any, 'somenpub', 'somepub')
@@ -203,6 +212,16 @@ describe('social handlers', () => {
       expect(result[2].petname).toBe('alice')
     })
 
+    it('takes highest created_at when multiple kind 3 events', async () => {
+      const pool = mockPool([
+        { kind: 3, pubkey: 'p', created_at: 500, tags: [['p', 'old']], content: '', id: '1', sig: 's' },
+        { kind: 3, pubkey: 'p', created_at: 1000, tags: [['p', 'new']], content: '', id: '2', sig: 's' },
+      ])
+      const result = await handleContactsGet(pool as any, 'npub', 'p')
+      expect(result.length).toBe(1)
+      expect(result[0].pubkey).toBe('new')
+    })
+
     it('returns empty when no kind 3 found', async () => {
       const pool = mockPool([])
       const result = await handleContactsGet(pool as any, 'somenpub', 'mypub')