Skip to content

Commit 971a0ef

Browse files
Merge pull request #2779 from generalaction/jan/eng-1773-branch-name-badges-are-not-centered-on-tasks-overview-page
fix(tasks): center PR badges
2 parents cfd67d2 + 48f0f39 commit 971a0ef

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

apps/emdash-desktop/src/renderer/lib/components/pr-badge.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,20 @@ export function PrBadge({ variant = 'default', pr, className, hoverDelay }: PrBa
2424
return (
2525
<div
2626
className={cn(
27-
'flex items-center gap-2 px-1.5 py-0.5 rounded-md bg-background-2 max-w-52',
27+
'flex h-5 max-w-52 items-center gap-1.5 rounded-md bg-background-2 px-1.5 leading-none',
2828
className
2929
)}
3030
>
3131
<StatusIcon className="size-3" pr={pr} disableTooltip />
32-
<PrNumberBadge number={getPrNumber(pr) ?? 0} className="text-[10px]" />
33-
<span className="truncate text-xs text-foreground-muted">{pr.title}</span>
32+
<span className="shrink-0 font-mono text-xs leading-none tracking-wide text-foreground-muted">
33+
#{getPrNumber(pr) ?? 0}
34+
</span>
35+
<span className="truncate text-xs leading-none text-foreground-muted">{pr.title}</span>
3436
</div>
3537
);
3638
case 'compact':
3739
return (
38-
<div className={cn('px-1 flex items-center justify-center', className)}>
40+
<div className={cn('flex h-5 items-center justify-center px-1 leading-none', className)}>
3941
<StatusIcon className="size-3" pr={pr} disableTooltip />
4042
</div>
4143
);
@@ -44,7 +46,7 @@ export function PrBadge({ variant = 'default', pr, className, hoverDelay }: PrBa
4446

4547
return (
4648
<Popover>
47-
<PopoverTrigger openOnHover delay={hoverDelay}>
49+
<PopoverTrigger className="flex items-center leading-none" openOnHover delay={hoverDelay}>
4850
{renderBadge()}
4951
</PopoverTrigger>
5052
<PopoverContent className="w-auto max-w-sm min-w-72">

0 commit comments

Comments
 (0)