Split oversized MUX modules

Author: gtaylor

CMakeLists.txt

@@ -310,6 +310,15 @@ if(BUILD_TESTING)
     "${CMAKE_SOURCE_DIR}/src")
   add_test(NAME event_timer COMMAND event_timer_test)
 
+  add_executable(red_black_tree_test tests/red_black_tree.c
+    ${MUX_SOURCE_DIR}/support/red_black_tree.c
+    ${MUX_SOURCE_DIR}/support/red_black_tree_mutation.c)
+  target_link_libraries(red_black_tree_test PRIVATE btmux_options)
+  target_include_directories(red_black_tree_test PRIVATE
+    "${CMAKE_BINARY_DIR}"
+    "${CMAKE_SOURCE_DIR}/src")
+  add_test(NAME red_black_tree COMMAND red_black_tree_test)
+
   add_executable(libuv_tcp_integration_test tests/libuv_tcp_integration.c)
   target_link_libraries(libuv_tcp_integration_test
     PRIVATE btmux_options SQLite3::SQLite3)

docs/content/en/docs/concepts/source-layout.md

@@ -26,6 +26,16 @@ descriptive PascalCase names. Functions use snake_case, and implementation
 details remain private to their owning module unless another translation unit
 needs them.
 
+Large subsystems use several translation units instead of collecting unrelated
+operations in one source file. Command registration, dispatch, configuration,
+listing, builder operations, state inspection, and examination are separate;
+channels separate delivery, aliases, management, presence, and administration;
+networking separates timing, output, connection lifecycle, commands, and site
+access; and SQLite and Lua code separate their schemas or runtimes from loading,
+storage, callbacks, scheduling, flows, and bindings. Headers ending in
+`_internal.h` are private contracts between translation units in one subsystem
+and must not be included by other subsystems.
+
 Object flags and powers are represented by individual boolean fields in memory
 and matching SQLite columns. Flags use `has_*_flag` names and powers use
 `has_*_power` names; command names omit those storage-oriented affixes (for

justfile

@@ -9,10 +9,13 @@ stylua := env_var_or_default("STYLUA", "stylua")
 
 default: fmt build test install
 
-ci: fmt-check build test
+ci: check-mux-source-size fmt-check build test
 
 agent-checks: ci
 
+check-mux-source-size:
+    status=0; while IFS= read -r -d '' source; do lines=$(awk 'END { print NR }' "$source"); if (( lines > 800 )); then echo "$source: $lines lines (maximum 800)"; status=1; fi; done < <(find src/mux -type f \( -name '*.c' -o -name '*.h' -o -name '*.h.in' \) -print0); exit "$status"
+
 fmt:
     find src -type f \( -name '*.c' -o -name '*.h' -o -name '*.h.in' \) -print0 | xargs -0 -r {{clang_format}} -i
     {{stylua}} --glob '**/*.lua' -- game/lua

src/mux/commands/builder_commands_internal.h

@@ -0,0 +1,10 @@
+/* Private helpers shared by builder command implementations. */
+
+#pragma once
+
+#include "mux/objects/db.h"
+
+typedef struct EvaluationContext EvaluationContext;
+
+char *builder_compile_object_name(EvaluationContext *evaluation, DbRef player,
+                                  const char *name);