Remove @password command in favor of @newpassword

@password and @newpassword were both wizard-only and functionally
redundant. Point admins at @newpassword for changing the default
God/Wizard passwords, and drop the now-unused PASS_MINE key.

Author: gtaylor

TODO

@@ -4,7 +4,6 @@
 
 * Do we still need object ownership?
 * verbs.c and verbs.h can probably be crunched elsewhere
-* Dedupe @newpassword and @password
 * Offer a non-privileged way to change your own password.
 * Add bad names list
 * Unit and integration test strategy for Lua

docs/content/en/docs/installation.md

@@ -45,7 +45,7 @@ If all goes well, you'll see a StompyMUX log stream.
 Use your preferred MUD client (or `telnet`) to connec to `localhost` port `5555`.
 There are two Wizard (admin) characters, `#1` (God) and `#2` (Wizard). They both
 have the same default password of `btmuxr0x`. Change these as soon as possible
-with the `@password` command.
+with the `@newpassword` command.
 
 ## Compile options
 

game/aliases.toml

@@ -74,7 +74,6 @@
 "@oemi" = "@oemit"
 "@op" = "@open"
 "@ope" = "@open"
-"@pass" = "@password"
 "@pcre" = "@pcreate"
 "@pe" = "@pemit"
 "@pem" = "@pemit"

src/mux/commands/command.c

@@ -334,12 +334,6 @@ CMDENT command_table[] = {
      CS_TWO_ARG,
      {.invoke = do_pemit}},
     {"@open", open_sw, CA_WIZARD, 0, CS_TWO_ARG | CS_ARGV, {.invoke = do_open}},
-    {"@password",
-     nullptr,
-     CA_WIZARD,
-     PASS_MINE,
-     CS_TWO_ARG,
-     {.invoke = do_password}},
     {"@pcreate",
      nullptr,
      CA_WIZARD,

src/mux/commands/command.h

@@ -88,8 +88,7 @@ void do_name(CommandInvocation *invocation);
 void do_newpassword(CommandInvocation *invocation);
 void do_notify(CommandInvocation *invocation); /* Notify or drain semaphore */
 void do_open(CommandInvocation *invocation);
-void do_page(CommandInvocation *invocation);     /* Message a faraway player. */
-void do_password(CommandInvocation *invocation); /* Change my password */
+void do_page(CommandInvocation *invocation); /* Message a faraway player. */
 void do_pcreate(CommandInvocation *invocation);
 void do_pemit(CommandInvocation *invocation); /* Message a specific object. */
 void do_power(CommandInvocation *invocation); /* Sets powers */

src/mux/server/server_api.h

@@ -181,7 +181,6 @@ constexpr int NFY_DRAIN = 2;      /* Delete waiting commands */
 constexpr int OPEN_LOCATION = 0;  /* Open exit in my location */
 constexpr int OPEN_INVENTORY = 1; /* Open exit in me */
 constexpr int PASS_ANY = 1;       /* name=newpass */
-constexpr int PASS_MINE = 2;      /* oldpass=newpass */
 constexpr int PCRE_PLAYER = 1;    /* create new player */
 constexpr int PEMIT_PEMIT = 1;    /* emit to named player */
 constexpr int PEMIT_OEMIT = 2;    /* emit to all in current room except named */

src/mux/world/player.c

@@ -286,35 +286,6 @@ DbRef create_player(EvaluationContext *evaluation, char *name, char *password) {
   return player;
 }
 
-/**
- * Change the password for a player
- */
-void do_password(CommandInvocation *invocation) {
-  EvaluationContext *evaluation = &invocation->context->evaluation;
-  DbRef player = invocation->player;
-  char *oldpass = invocation->first;
-  char *newpass = invocation->second;
-  WorldContext *world = invocation->context->world;
-  DbRef aowner;
-  long aflags;
-  char hashed_password[crypto_pwhash_STRBYTES];
-  char *target;
-
-  target = attribute_get(world->database, player, A_PASS, &aowner, &aflags);
-  if (!*target || !check_pass(world, player, oldpass)) {
-    notify(evaluation, player, "Sorry.");
-  } else if (!ok_password(world->configuration, newpass)) {
-    notify(evaluation, player, "Bad new password.");
-  } else if (!password_hash(world->configuration, newpass, hashed_password)) {
-    notify(evaluation, player, "Unable to change password.");
-  } else {
-    attribute_add_raw(world->database, player, A_PASS, hashed_password);
-    sodium_memzero(hashed_password, sizeof(hashed_password));
-    notify(evaluation, player, "Password changed.");
-  }
-  free_lbuf(target);
-}
-
 /**
  * Display login history data.
  */

src/mux/world/player.h

@@ -23,5 +23,4 @@ void badname_remove(WorldContext *world, char *name);
 int badname_check(WorldContext *world, char *name);
 void badname_list(EvaluationContext *evaluation, WorldContext *world,
                   DbRef player, const char *name);
-void do_password(CommandInvocation *invocation);
 void do_last(CommandInvocation *invocation);