Remove TODO for passing state

beatrycze-volk · beatrycze-volk · commit 38e504fcf0e5 · 2025-10-13T15:57:11.000+02:00
It looks like the page and simultaneousPages can be undefined, so better to avoid overwrite data with undefined
diff --git a/Resources/Public/JavaScript/PageView/Controller.js b/Resources/Public/JavaScript/PageView/Controller.js
@@ -124,7 +124,6 @@ class dlfController {
      * @param {dlf.StateChangeDetail} detail
      */
     changeState(detail) {
-        // TODO(client-side): Consider passing full new state in stateChanged event, then reduce usage of currentPageNo and simultaneousPages properties
         if (detail.page !== undefined) {
             this.doc.state.page = detail.page;
         }

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,6 @@ class dlfController {`
`124`	`124`	`* @param {dlf.StateChangeDetail} detail`
`125`	`125`	`*/`
`126`	`126`	`changeState(detail) {`
`127`		`- // TODO(client-side): Consider passing full new state in stateChanged event, then reduce usage of currentPageNo and simultaneousPages properties`
`128`	`127`	`if (detail.page !== undefined) {`
`129`	`128`	`this.doc.state.page = detail.page;`
`130`	`129`	`}`