From 4d9bebbf53c90c8f5827d2387cb8f9c89d627833 Mon Sep 17 00:00:00 2001
From: Alexandre Vincent <alexandre.vincent@stellar.tc>
Date: Mon, 22 Jun 2026 18:33:59 +0200
Subject: [PATCH] Remove unnecessary fill(0) before drop

---
 src/http/request.rs      | 25 +++++--------------------
 src/results/telemetry.rs |  1 -
 2 files changed, 5 insertions(+), 21 deletions(-)

diff --git a/src/http/request.rs b/src/http/request.rs
index 361d94d..fa78e27 100644
--- a/src/http/request.rs
+++ b/src/http/request.rs
@@ -62,20 +62,14 @@ F: Send + Sync + Fn(Request) -> Pin<Box<dyn Future<Output = Response> + Send>>
                                     loop {
                                         let bytes_read = buf_reader.read_exact(&mut buffer).await;
                                         match bytes_read {
-                                            Ok(0) => {
-                                                buffer.fill(0);
-                                                break;
-                                            }
+                                            Ok(0) => break,
                                             Ok(_) => {
                                                 len += buffer.len();
                                                 if len >= body_size as usize {
-                                                    buffer.fill(0);
                                                     break;
                                                 }
                                             }
-                                            Err(_) => {
-                                                break;
-                                            }
+                                            Err(_) => break,
                                         }
                                     }
                                     None
@@ -90,16 +84,9 @@ F: Send + Sync + Fn(Request) -> Pin<Box<dyn Future<Output = Response> + Send>>
                             loop {
                                 let bytes_read = buf_reader.read_exact(&mut buffer).await;
                                 match bytes_read {
-                                    Ok(0) => {
-                                        buffer.fill(0);
-                                        break;
-                                    }
-                                    Ok(_) => {
-                                        buffer.fill(0);
-                                    }
-                                    Err(_) => {
-                                        break;
-                                    }
+                                    Ok(0) => break,
+                                    Ok(_) => {}
+                                    Err(_) => break,
                                 }
                             }
                             None
@@ -113,7 +100,6 @@ F: Send + Sync + Fn(Request) -> Pin<Box<dyn Future<Output = Response> + Send>>
                                             let mut body = Vec::with_capacity(body_size as usize);
                                             buf_reader.take(body_size).read_to_end(&mut body).await.unwrap();
                                             let form_data = parse_form_data(&form_boundary,&body);
-                                            body.fill(0);
                                             Some(form_data)
                                         }
                                         None => {
@@ -132,7 +118,6 @@ F: Send + Sync + Fn(Request) -> Pin<Box<dyn Future<Output = Response> + Send>>
                                     let mut body = Vec::with_capacity(body_size as usize);
                                     buf_reader.take(body_size).read_to_end(&mut body).await.unwrap();
                                     let form_data = parse_form_url_encoded(&body);
-                                    body.fill(0);
                                     Some(form_data)
                                 }
                                 None => {
diff --git a/src/results/telemetry.rs b/src/results/telemetry.rs
index 39b899e..3a3612e 100644
--- a/src/results/telemetry.rs
+++ b/src/results/telemetry.rs
@@ -222,7 +222,6 @@ pub fn draw_result (data : &TelemetryData) -> Vec<u8> {
     if let Err(e) = img.write_to(&mut buffer, ImageFormat::Jpeg) {
         error!("Image writer buffer error : {e}")
     }
-    img.fill(0);
     drop(img);
 
     buffer.into_inner()