[fix] Add comments and remove hardcode url

Author: dee077

openwisp_monitoring/device/static/monitoring/js/device-map.js

@@ -197,9 +197,12 @@
     let activeRequest = null;
     let loading = false;
     function fetchDevices(url, ms = 0, append) {
+      // Nothing to fetch if there's no URL (e.g. last page reached).
       if (!url) return;
+      // Skip duplicate scroll fetches; abort stale filter fetches.
       if (append && loading) return;
       clearTimeout(fetchDevicesTimeout);
+      // Abort pending filter/search to prevent stale data.
       if (!append && activeRequest) {
         activeRequest.abort();
       }
@@ -219,24 +222,26 @@
         container.css("--table-spinner-top", `${spinnerTop}px`);
         container.addClass("is-loading-append");
       }
+      // Debounce — wait ms (0/100/300ms) so rapid events (scroll/input) coalesce before the AJAX call.
       fetchDevicesTimeout = setTimeout(() => {
         let params = new URLSearchParams();
         const searchParam = el.find("#device-search").val().toLowerCase().trim();
         const statusParam = el.find("#status-filter").val();
         if (searchParam) {
           params.append("search", searchParam);
         }
-
         if (statusParam) {
           statusParam.split(",").forEach((status) => {
             params.append("status", status);
           });
         }
         const queryString = params.toString();
+        // Two fetch paths:
+        // 1. Infinite scroll (append=true): use the pagination URL passed as-is.
+        // 2. Filter/search (append=false): build URL by appending query params to base URL.
         let fetchUrl;
-        // if append is true, that means we are fetching for infinite scroll
         if (append) {
-          fetchUrl = url; // url is nextUrl, already contains params
+          fetchUrl = url;
         } else {
           fetchUrl = queryString ? `${url}?${queryString}` : url;
         }
@@ -255,6 +260,7 @@
             if (!append) container.scrollTop(0);
           },
           error(_jqXHR, textStatus) {
+            // Ignore aborted requests.
             if (textStatus === "abort") return;
             console.error(gettext("Could not load more devices from"), url);
             alert(gettext("Could not load more devices."));

openwisp_monitoring/device/static/monitoring/js/location-inline.js

@@ -13,12 +13,13 @@
       return;
     }
 
+    const mapPageUrl = window._owMapPageUrl;
     const openLocationBtn = `
       <div class="form-row field-location-view-button view-on-map-div">
         <div>
           <div class="flex-container">
             <label for="id_devicelocation-0-map">${gettext("Map:")}</label>
-            <a href="/admin/device_monitoring/map#${geoMapId}"
+            <a href="${mapPageUrl}#${geoMapId}"
               id="open-location-btn"
               class="default-btn view-on-map-btn">
                 ${gettext("View on General Map")}
@@ -42,7 +43,7 @@
         <div>
           <div class="flex-container">
             <label for="id_devicelocation-0-indoor_map">${gettext("Map:")}</label>
-            <a href="/admin/device_monitoring/map#${geoMapId};${indoorMapId}"
+            <a href="${mapPageUrl}#${geoMapId};${indoorMapId}"
               id="open-indoor-device-btn"
               class="default-btn view-on-map-btn">
                 ${gettext("View on General Indoor Map")}

openwisp_monitoring/device/templates/admin/monitoring/device/change_form.html

@@ -1,5 +1,5 @@
 {% extends "admin/config/device/change_form.html" %}
-{% load i18n static %}
+{% load i18n static admin_urls %}
 {% block after_field_sets %}
 {% if not add and device_data %}
 <div class="inline-group" id="ow-device-status">
@@ -607,3 +607,10 @@ <h2>{% trans 'Charts' %}</h2>
 </script>
 {% endif %}
 {% endblock %}
+
+{% block admin_change_form_document_ready %}
+{{ block.super }}
+<script>
+    window._owMapPageUrl = "{% url 'admin:device_monitoring_map_changelist' %}";
+</script>
+{% endblock %}