initial attempt

Author: Marcin Matlag

net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditBGPNeighbor.xml

@@ -70,7 +70,7 @@
     <label>Local Initiater IP</label>
     <type>text</type>
     <advanced>true</advanced>
-    <help>Specify the local IP address used to establish connections with the neighbor. Only relevant for MD5 authentication.</help>
+    <help>Specify the local IP address (IPv4 or IPv6) used as the source to initiate BGP/BFD sessions and connections with the neighbor, including MD5 authentication. Takes precedence over Update-Source Interface when set.</help>
     <grid_view>
       <visible>false</visible>
     </grid_view>

net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/BGP.php

@@ -2,6 +2,7 @@
 
 namespace OPNsense\Quagga;
 
+use OPNsense\Base\Messages\Message;
 use OPNsense\Base\BaseModel;
 
 /*
@@ -28,4 +29,23 @@
 */
 class BGP extends BaseModel
 {
+    /**
+     * {@inheritdoc}
+     */
+    public function performValidation($validateFullModel = false)
+    {
+        $messages = parent::performValidation($validateFullModel);
+        foreach ($this->neighbors->neighbor->iterateItems() as $neighbor) {
+            if (!$validateFullModel && !$neighbor->isFieldChanged()) {
+                continue;
+            }
+            if (!$neighbor->updatesource->isEmpty() && !$neighbor->localip->isEmpty()) {
+                $messages->appendMessage(new Message(
+                    gettext("Update-Source Interface and Local Initiator IP are mutually exclusive."),
+                    $neighbor->updatesource->__reference
+                ));
+            }
+        }
+        return $messages;
+    }
 }

net/frr/src/opnsense/mvc/app/views/OPNsense/Quagga/bgp.volt

@@ -38,6 +38,16 @@ POSSIBILITY OF SUCH DAMAGE.
             }
         });
 
+        function checkNeighborSourceConflict() {
+            const $block = $('#help_block_neighbor\\.updatesource');
+            if ($('#neighbor\\.updatesource').val() && $('#neighbor\\.localip').val()) {
+                $block.text('{{ lang._("Update-Source Interface and Local Initiator IP are mutually exclusive.") }}');
+            } else {
+                $block.text('');
+            }
+        }
+        $(document).on('change', '#neighbor\\.updatesource, #neighbor\\.localip', checkNeighborSourceConflict);
+
         mapDataToFormUI({'frm_bgp_settings':"/api/quagga/bgp/get"}).done(function(data){
             formatTokenizersUI();
             $('.selectpicker').selectpicker('refresh');

net/frr/src/opnsense/service/templates/OPNsense/Quagga/bgpd.conf

@@ -138,7 +138,9 @@ router bgp {{ OPNsense.quagga.bgp.asnumber }}
 {%         if 'disable_connected_check' in neighbor and neighbor.disable_connected_check == '1' %}
  neighbor {{ neighbor.address }} disable-connected-check
 {%         endif %}
-{%         if ':' not in neighbor.address and 'updatesource' in neighbor and neighbor.updatesource != '' %}
+{%         if 'localip' in neighbor and neighbor.localip != '' %}
+ neighbor {{ neighbor.address }} update-source {{ neighbor.localip }}
+{%         elif ':' not in neighbor.address and 'updatesource' in neighbor and neighbor.updatesource != '' %}
  neighbor {{ neighbor.address }} update-source {{ physical_interface(neighbor.updatesource) }}
 {%         endif %}
 {%         if ':' in neighbor.address and 'linklocalinterface' in neighbor and neighbor.linklocalinterface != '' %}