Add missing cosmo temperature sensors#2578
Conversation
| rail_controller_notemp!(Core, isl68224, v1p8_sp5_a1, A0), // XXX A0 or A2? | ||
| rail_controller_notemp!(Core, isl68224, v3p3_sp5_a1, A0), // XXX A0 or A2? | ||
| rail_controller!(Core, isl68224, v1p1_sp5_a0, A0), | ||
| rail_controller!(Core, isl68224, v1p8_sp5_a1, A0), // XXX A0 or A2? |
There was a problem hiding this comment.
@mkeeter do we know better now whether this should be A0 or A2?
There was a problem hiding this comment.
I think it should be A2, because the chip generates the A0 rail (but is itself powered by A2 rails). We should test it, though!
There was a problem hiding this comment.
Is there a specific way you'd suggest to test this, or just "make the change and see if a cosmo sled still boots happily about it"?
There was a problem hiding this comment.
Basically! Make the change above (with A2 instead of A0), put a Cosmo sled into A2 (humility hiffy -c Sequencer.set_state -a state=A2), and confirm that it's still happily reading temperatures (with humility sensors)
|
I'll test the scenario Matt suggested today and get this merged. |
3 participants
Closes #2577.
This is a similar change to #2108, but for Cosmo instead of gimlet. I took a look, and the only other apps with this ISL sensor are the gimlet-bu target (which has no sensors), and sidecar (which already has these temp sensors mapped).