fix(*): fix some clippy warnings

Author: pauldcs

src/dynld.rs

@@ -61,15 +61,17 @@ pub fn dynamically_link(
         loaded_dylibs.push(lib_name);
     }
 
-    fixup_all_chained_fixups(
-        vm.as_ptr() as *mut u8,
-        PAGE_ZERO_SIZE,
-        &parsed.fixups,
-        &parsed.symbols,
-        &loaded_dylibs,
-        Some(dyld_shared_cache),
-        false,
-    )?;
+    unsafe {
+        fixup_all_chained_fixups(
+            vm.as_ptr() as *mut u8,
+            PAGE_ZERO_SIZE,
+            &parsed.fixups,
+            &parsed.symbols,
+            &loaded_dylibs,
+            Some(dyld_shared_cache),
+            false,
+        )?
+    };
 
     apply_segment_protections(vm, &parsed.segments)?;
     run_initializers(vm, &parsed.init_functions);

src/fixups.rs

@@ -110,7 +110,7 @@ impl<'bytes> Image<'bytes> {
             next_load_command_offset += cmdsize as usize;
         }
 
-        return if contains_fixups_header {
+        if contains_fixups_header {
             // a LC_DYLD_CHAINED_FIXUPS is a linkedit_data_command. We need to extract `dataoff` from
             // it. This will tell us where the `dyld_chained_fixups_header` is located at
             let linkedit_data_command { dataoff, .. } = self
@@ -126,7 +126,7 @@ impl<'bytes> Image<'bytes> {
             )))
         } else {
             Ok(None)
-        };
+        }
     }
 
     /// Applies all fixups to the image
@@ -474,7 +474,7 @@ impl<'bytes> Image<'bytes> {
     }
 }
 
-pub fn fixup_all_chained_fixups(
+pub unsafe fn fixup_all_chained_fixups(
     dst_ptr: *mut u8,
     page_zero_size: usize,
     fixups: &Vec<Fixup>,
@@ -522,7 +522,7 @@ pub fn fixup_all_chained_fixups(
                         let symbol = symbols
                             .iter()
                             .find(|sym| sym.array_string_cmp(symbol_name))
-                            .ok_or_else(|| "could not find a matching symbol while fixing up a BIND_SPECIAL_DYLIB_WEAK_LOOKUP")?;
+                            .ok_or("could not find a matching symbol while fixing up a BIND_SPECIAL_DYLIB_WEAK_LOOKUP")?;
 
                         *dst_addr = (dst_ptr.add(symbol.impl_offset).addr()) as u64;
                     },

src/main.rs

@@ -1,7 +1,5 @@
 #![no_std]
 #![no_main]
-#![deny(unsafe_op_in_unsafe_fn)]
-//#![deny(clippy::undocumented_unsafe_blocks)]
 
 use crate::{
     allocator::{Allocator, VM},
@@ -133,19 +131,21 @@ fn rebase_self_and_extract_bind_fixups(self_header: *mut u8, self_size: usize) -
             if !fixups.is_empty() {
                 // unwrap if this does not work, we might want to return
                 // a proper error instead though
-                fixup_all_chained_fixups(
-                    self_header,
-                    0,
-                    &fixups,
-                    &Vec::new(),
-                    &ArrayVec::new_array(),
-                    None,
-                    true,
-                )
-                .map_err(|_| {
-                    let _ = libc::write(STDERR_FILENO, b"self rebase error, exiting ...\n");
-                    exit_error()
-                });
+                unsafe {
+                    fixup_all_chained_fixups(
+                        self_header,
+                        0,
+                        &fixups,
+                        &Vec::new(),
+                        &ArrayVec::new_array(),
+                        None,
+                        true,
+                    )
+                    .map_err(|_| {
+                        let _ = libc::write(STDERR_FILENO, b"self rebase error, exiting ...\n");
+                        exit_error()
+                    })
+                };
             };
             // we return the bind fixups, as we cannot handle them right now. We first need to load
             // the shared cache first