[COM-193] Lock compute provider for new deployment versions (#3674)

rossnelson · web-flow · commit 51164cb4d3c5 · 2026-07-16T16:50:36.000-04:00
* fix(deployments): lock provider for new versions

* feat(deployments): allow hiding unsupported create action
diff --git a/src/lib/components/deployments/deployments-empty-state.svelte b/src/lib/components/deployments/deployments-empty-state.svelte
@@ -8,9 +8,14 @@
   interface Props {
     createHref: string;
     error?: string;
+    canCreateServerlessDeployment?: boolean;
   }
 
-  let { createHref, error = '' }: Props = $props();
+  let {
+    createHref,
+    error = '',
+    canCreateServerlessDeployment = true,
+  }: Props = $props();
 </script>
 
 <div class="flex flex-col items-center gap-4 py-16">
@@ -24,11 +29,13 @@
     </p>
   </div>
   <div class="flex flex-wrap items-center justify-center gap-4">
-    <CapabilityGuard capability="serverScaledDeployments">
-      <Button variant="secondary" href={createHref}>
-        {translate('deployments.create-serverless-deployment')}
-      </Button>
-    </CapabilityGuard>
+    {#if canCreateServerlessDeployment}
+      <CapabilityGuard capability="serverScaledDeployments">
+        <Button variant="secondary" href={createHref}>
+          {translate('deployments.create-serverless-deployment')}
+        </Button>
+      </CapabilityGuard>
+    {/if}
     <Button
       variant="ghost"
       href="https://docs.temporal.io/worker-deployments"
diff --git a/src/lib/components/workers/serverless-worker-form/create-version-form.svelte b/src/lib/components/workers/serverless-worker-form/create-version-form.svelte
@@ -27,6 +27,7 @@
     error?: string;
     versions?: VersionSummary[];
     computeProviders?: readonly ComputeProviderOption[];
+    initialProvider?: ComputeProviderOption['value'];
     gcpRegions?: string[];
   }
 
@@ -36,13 +37,15 @@
     error,
     versions = [],
     computeProviders,
+    initialProvider,
     gcpRegions,
   }: Props = $props();
 
   const superform = superForm(
     {
       buildId: '',
       provider: getInitialComputeProvider({
+        provider: untrack(() => initialProvider),
         providers: untrack(() => computeProviders),
       }),
       lambdaArn: '',
diff --git a/src/lib/pages/deployments.svelte b/src/lib/pages/deployments.svelte
@@ -20,6 +20,12 @@
   import { has } from '$lib/utilities/has';
   import { routeForWorkerDeploymentCreate } from '$lib/utilities/route-for';
 
+  interface Props {
+    canCreateServerlessDeployment?: boolean;
+  }
+
+  let { canCreateServerlessDeployment = true }: Props = $props();
+
   let error = $state('');
 
   const namespace = $derived(page.params.namespace);
@@ -102,7 +108,11 @@
       {/each}
 
       <svelte:fragment slot="empty">
-        <DeploymentsEmptyState {createHref} {error} />
+        <DeploymentsEmptyState
+          {createHref}
+          {error}
+          {canCreateServerlessDeployment}
+        />
       </svelte:fragment>
       <svelte:fragment slot="actions-end-additional">
         <Tooltip text="Configure Columns" top>
diff --git a/src/lib/pages/worker-deployment-version-create.svelte b/src/lib/pages/worker-deployment-version-create.svelte
@@ -1,6 +1,7 @@
 <script lang="ts">
   import CreateVersionForm from '$lib/components/workers/serverless-worker-form/create-version-form.svelte';
   import type { ComputeProviderOption } from '$lib/components/workers/serverless-worker-form/shared';
+  import Alert from '$lib/holocene/alert.svelte';
   import Link from '$lib/holocene/link.svelte';
   import { translate } from '$lib/i18n/translate';
   import {
@@ -12,6 +13,7 @@
     validateWorkerDeploymentVersionComputeConfig,
   } from '$lib/services/deployments-service';
   import type { VersionSummary } from '$lib/types/deployments';
+  import { lockComputeProvider } from '$lib/utilities/lock-compute-provider';
   import { routeForWorkerDeployment } from '$lib/utilities/route-for';
 
   interface Props {
@@ -32,12 +34,20 @@
 
   let error = $state<string | undefined>();
   let versions = $state<VersionSummary[]>();
+  let lockedProvider = $state<ReturnType<typeof lockComputeProvider>>();
+  let loading = $state(true);
+  let loadError = $state(false);
 
   const backHref = $derived(
     routeForWorkerDeployment({ namespace, deployment }),
   );
 
   $effect(() => {
+    loading = true;
+    loadError = false;
+    versions = undefined;
+    lockedProvider = undefined;
+
     const controller = new AbortController();
     fetchDeployment(
       { namespace, deploymentName: deployment },
@@ -48,11 +58,21 @@
     )
       .then((response) => {
         if (controller.signal.aborted) return;
-        versions = response?.workerDeploymentInfo?.versionSummaries ?? [];
+        const info = response?.workerDeploymentInfo;
+        if (!info) {
+          loadError = true;
+          return;
+        }
+        versions = info.versionSummaries ?? [];
+        lockedProvider = lockComputeProvider(info, computeProviders);
+        loadError = versions.length > 0 && !lockedProvider;
       })
       .catch(() => {
         if (controller.signal.aborted) return;
-        versions = [];
+        loadError = true;
+      })
+      .finally(() => {
+        if (!controller.signal.aborted) loading = false;
       });
     return () => controller.abort();
   });
@@ -65,85 +85,92 @@
   <h1>
     {translate('workers.create-version-title')}
   </h1>
-  <CreateVersionForm
-    {error}
-    {versions}
-    {computeProviders}
-    {gcpRegions}
-    cancelHref={backHref}
-    onSubmit={async (data) => {
-      error = undefined;
-      const computeConfig =
-        data.provider === 'cloud-run'
-          ? buildGcpCloudRunComputeConfig(
-              data.gcpProject,
-              data.gcpRegion,
-              data.gcpWorkerPool,
-              data.gcpServiceAccount,
-            )
-          : buildLambdaComputeConfig(data.lambdaArn, data.iamRoleArn, {
-              roleExternalId: data.roleExternalId,
-              scaleUpCooloffMs: data.scaleUpCooloffMs,
-              scaleUpBacklogThreshold: data.scaleUpBacklogThreshold,
-              maxWorkerLifetimeMs: data.maxWorkerLifetimeMs,
-              metricsPollIntervalMs: data.metricsPollIntervalMs,
-            });
-      await createWorkerDeploymentVersion(
-        {
-          namespace,
-          deploymentVersion: {
+  {#if loadError}
+    <Alert intent="error" title={translate('common.error-occurred')}>
+      {translate('common.unknown-error')}
+    </Alert>
+  {:else if !loading}
+    <CreateVersionForm
+      {error}
+      {versions}
+      computeProviders={lockedProvider?.providers ?? computeProviders}
+      initialProvider={lockedProvider?.provider}
+      {gcpRegions}
+      cancelHref={backHref}
+      onSubmit={async (data) => {
+        error = undefined;
+        const computeConfig =
+          data.provider === 'cloud-run'
+            ? buildGcpCloudRunComputeConfig(
+                data.gcpProject,
+                data.gcpRegion,
+                data.gcpWorkerPool,
+                data.gcpServiceAccount,
+              )
+            : buildLambdaComputeConfig(data.lambdaArn, data.iamRoleArn, {
+                roleExternalId: data.roleExternalId,
+                scaleUpCooloffMs: data.scaleUpCooloffMs,
+                scaleUpBacklogThreshold: data.scaleUpBacklogThreshold,
+                maxWorkerLifetimeMs: data.maxWorkerLifetimeMs,
+                metricsPollIntervalMs: data.metricsPollIntervalMs,
+              });
+        await createWorkerDeploymentVersion(
+          {
+            namespace,
+            deploymentVersion: {
+              deploymentName: deployment,
+              buildId: data.buildId,
+            },
+            computeConfig,
+          },
+          (err) => {
+            error =
+              err.body?.message ||
+              err.statusText ||
+              translate('workers.create-version-error');
+          },
+        );
+        if (error) return;
+
+        let validateError: string | undefined;
+        const validation = await validateWorkerDeploymentVersionComputeConfig(
+          {
+            namespace,
             deploymentName: deployment,
             buildId: data.buildId,
+            computeConfig,
           },
-          computeConfig,
-        },
-        (err) => {
-          error =
-            err.body?.message ||
-            err.statusText ||
-            translate('workers.create-version-error');
-        },
-      );
-      if (error) return;
-
-      let validateError: string | undefined;
-      const validation = await validateWorkerDeploymentVersionComputeConfig(
-        {
-          namespace,
-          deploymentName: deployment,
-          buildId: data.buildId,
-          computeConfig,
-        },
-        (err) => {
-          if (err.status === 501) return;
-          validateError =
-            err.body?.message ||
-            err.statusText ||
-            translate('workers.create-version-error');
-        },
-      );
+          (err) => {
+            if (err.status === 501) return;
+            validateError =
+              err.body?.message ||
+              err.statusText ||
+              translate('workers.create-version-error');
+          },
+        );
 
-      if (!validateError && (!validation || validation.valid !== false)) {
-        await onSuccess();
-        return;
-      }
+        if (!validateError && (!validation || validation.valid !== false)) {
+          await onSuccess();
+          return;
+        }
 
-      const message =
-        validation?.message ??
-        validateError ??
-        translate('workers.create-version-error');
+        const message =
+          validation?.message ??
+          validateError ??
+          translate('workers.create-version-error');
 
-      let rollbackFailed = false;
-      await deleteWorkerDeploymentVersion(
-        { namespace, deploymentName: deployment, buildId: data.buildId },
-        () => {
-          rollbackFailed = true;
-        },
-      );
+        let rollbackFailed = false;
+        await deleteWorkerDeploymentVersion(
+          { namespace, deploymentName: deployment, buildId: data.buildId },
+          () => {
+            rollbackFailed = true;
+          },
+        );
 
-      error = rollbackFailed
-        ? translate('workers.create-version-rollback-failed', { message })
-        : message;
-    }}
-  />
+        error = rollbackFailed
+          ? translate('workers.create-version-rollback-failed', { message })
+          : message;
+      }}
+    />
+  {/if}
 </div>
diff --git a/src/lib/utilities/lock-compute-provider.test.ts b/src/lib/utilities/lock-compute-provider.test.ts
diff --git a/src/lib/utilities/lock-compute-provider.ts b/src/lib/utilities/lock-compute-provider.ts
