Commit cb49561
committed
Say out loud that these cells need a case sensitive filesystem
The Hub branch of check_model_quantization_status is only reachable when
os.path.exists(name) misses while check_local_model_exists(name) hits, and a case
difference is the only thing that produces that: case insensitive matching is the
entire purpose of that helper, so there is no filesystem independent way to write
the shape. `Outputs/MyModel` against an on-disk `outputs/mymodel` is it.
On macOS APFS and Windows NTFS os.path.exists answers True for `Outputs/MyModel`,
so the local branch is taken and the Hub round trip these five cells are named for
never happens. They would then pass while exercising nothing, which is the same
kind of quiet false confidence as a green check on tests CI never executed.
So probe the filesystem and skip with the reason, rather than leaving the
assumption implicit. On a case sensitive filesystem nothing changes: 28 passed,
no skips. Checked the guard both ways by substituting a case insensitive
os.path.exists, so it is not decorative.
Found by running the branch on macos-14 and windows-latest, which nothing in CI
does today.1 parent d117647 commit cb49561
1 file changed
Lines changed: 30 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
328 | 330 | | |
329 | 331 | | |
330 | 332 | | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
331 | 356 | | |
332 | 357 | | |
333 | 358 | | |
| |||
339 | 364 | | |
340 | 365 | | |
341 | 366 | | |
| 367 | + | |
342 | 368 | | |
343 | 369 | | |
344 | 370 | | |
| |||
357 | 383 | | |
358 | 384 | | |
359 | 385 | | |
| 386 | + | |
360 | 387 | | |
361 | 388 | | |
362 | 389 | | |
| |||
372 | 399 | | |
373 | 400 | | |
374 | 401 | | |
| 402 | + | |
375 | 403 | | |
376 | 404 | | |
377 | 405 | | |
| |||
385 | 413 | | |
386 | 414 | | |
387 | 415 | | |
| 416 | + | |
388 | 417 | | |
389 | 418 | | |
390 | 419 | | |
| |||
403 | 432 | | |
404 | 433 | | |
405 | 434 | | |
| 435 | + | |
406 | 436 | | |
407 | 437 | | |
408 | 438 | | |
| |||
0 commit comments