Fix: Check for watchdog-based self-fencing device only if "fencing-watchdog-timeout" is enabled#4146
Open
gao-yan wants to merge 4 commits into
Open
Fix: Check for watchdog-based self-fencing device only if "fencing-watchdog-timeout" is enabled#4146gao-yan wants to merge 4 commits into
gao-yan wants to merge 4 commits into
Conversation
… "fencing-watchdog-timeout" is enabled With 14e9b3e, stonith__watchdog_fencing_enabled_for_node_api() was called only if "stonith-watchdog-timeout" was enabled (non-zero). But with a4f2db3, the function is again always called even if the cluster option is not enabled, so that it again keeps logging the confusing notice "Cluster does not have watchdog fencing". This commit fixes the regression by anyway parsing the value of the cluster option first and avoiding calling stonith__watchdog_fencing_enabled_for_node_api() if the cluster option is not even enabled.
…es only if "fencing-watchdog-timeout" is enabled Previously, stonith__watchdog_fencing_enabled_for_node_api() was always called even when "fencing-watchdog-timeout" was disabled. This resulted in a constant, confusing log notice: "Cluster does not have watchdog fencing device". This commit fixes it by ensuring the watchdog-based self-fencing device for remote nodes is only checked when the cluster option is actually enabled.
…atic Now it's only used within the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 14e9b3e, stonith__watchdog_fencing_enabled_for_node_api() was
called only if "stonith-watchdog-timeout" was enabled (non-zero). But
with a4f2db3, the function is again always called even if the cluster
option is not enabled, so that it again keeps logging the confusing
notice "Cluster does not have watchdog fencing".
Besides, in liblrmd, stonith__watchdog_fencing_enabled_for_node_api()
has always been called for remote nodes even if "fencing-watchdog-timeout"
is disabled.
This PR fixes the issues by ensuring the watchdog-based self-fencing device
is only checked when "fencing-watchdog-timeout" is actually enabled.