Allow Helm to omit Deployment replicas#214
Open
CodeTogetherBot wants to merge 1 commit into
Open
Conversation
CodeTogetherBot
force-pushed
the
publish/codetogether-ai-helm-chart
branch
from
ac1b771 to
5366953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manageReplicasto the CodeTogether AI Helm chart, defaulting totrueto preserve current behavior.spec.replicaswhenmanageReplicas=falseso external scalers or automation can own replica count without server-side apply conflicts..spec.replicasconflict symptom and customer workaround.Validation
/tmp/helm-v3.15.4-linux-amd64/helm template codetogether-ai . -f values.yaml --set service.fqdn=https://ai.example.comrendersreplicas: 1by default./tmp/helm-v3.15.4-linux-amd64/helm template codetogether-ai . -f values.yaml --set service.fqdn=https://ai.example.com --set manageReplicas=falseomitsreplicas./tmp/helm-v3.15.4-linux-amd64/helm lint . --set service.fqdn=https://ai.example.compassed.Notes
CodeTogether-Inc/ct-aion branchworktree/helm-deployment-control-086c02.