Fix iOS MediaElement support for multiple ItemsViews and windows#3222
Open
ne0rrmatrix wants to merge 6 commits into
Open
Fix iOS MediaElement support for multiple ItemsViews and windows#3222ne0rrmatrix wants to merge 6 commits into
ne0rrmatrix wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes iOS/MacCatalyst MediaElement failures in templated and multi-window scenarios by attaching AVPlayerViewController using the actual UIKit responder-chain parent view controller (instead of inferring it from MAUI page/items-view state), and adds shared helpers/tests for resolving current pages across multiple windows.
Changes:
- Update iOS/MacCatalyst
MauiMediaElementto attach/detachAVPlayerViewControllerbased on the UIKit responder chain (supporting multipleItemsViews and multiple windows). - Add a shared
TryGetCurrentPageshelper to enumerate the “current page” per window. - Add unit coverage validating multi-window current-page resolution.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/CommunityToolkit.Maui.UnitTests/Views/MediaElement/ParentWindowTests.cs | Adds a unit test asserting current-page resolution across multiple windows. |
| src/CommunityToolkit.Maui.MediaElement/Views/MauiMediaElement.macios.cs | Reworks iOS/MacCatalyst parent view controller attachment logic to use the UIKit responder chain. |
| src/CommunityToolkit.Maui.MediaElement/Extensions/PageExtensions.shared.cs | Adds multi-window current-page enumeration and updates parent-window current-page resolution. |
… and MauiMediaElement
…exception when no active windows are found
…ility and performance
dotnet-policy-service
Bot
added
stale
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
MediaElement was throwing in templated iOS/MacCatalyst scenarios when:
Using the actual rendered UIKit hierarchy avoids the brittle handler-selection logic that caused both failures.
Fixes #2247
Fixes #2249
Validation