Allow passing a specific directory to rule-preprocessor#226
Open
joaotgouveia wants to merge 1 commit into
Open
Allow passing a specific directory to rule-preprocessor#226joaotgouveia wants to merge 1 commit into
joaotgouveia wants to merge 1 commit into
Conversation
lucic71
reviewed
Jul 2, 2026
| let out_dir = args | ||
| .next() | ||
| .expect("usage: rule-preprocessor <out-dir> [rules-crate-dir]"); | ||
| let in_dir = args.next().unwrap_or_else(|| "../rules".to_string()); |
Contributor
There was a problem hiding this comment.
I think you should terminate the program if the dir is not found. Otherwise it will create confusion when someone wants to use dir X and instead it fallbacks to rules/
Contributor
Author
There was a problem hiding this comment.
The fallback to ../rules only happens when the argument is not provided, i.e., it acts as a default argument. If the provided directory is not found, the program terminates with a No such file or directory error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional command-line argument that allows specifying a directory other than the default
../rules.