[521] Add support for new API for adding groups for versions >= 4.3.4 - #522
Conversation
korydraughn
left a comment
There was a problem hiding this comment.
Change look good.
Please add a test for this. We need to make sure the new test passes against 4.3.3 and 5.0.1.
korydraughn
left a comment
There was a problem hiding this comment.
Looks good. Squash it.
There is already a test that covers this. It is As for testing against 4.3.3 and 5.0.1, that was tested via point Metalnx to iRODS servers at these versions (as well as 4.3.4). We don't have a testing environment setup to run the unit test listed above in 4.3.3 and 5.0.1 at the moment though I did open an issue to create a 5-0 testing environment setup. |
caccde6 to
120a871
Compare
Done |
120a871 to
3700928
Compare
done |
I tested adding groups via metalnx in 4.3.3, 4.3.4, and 4.3.5. The jargon-core tests also passed.