Only Rebuild the Vendor that updated.#11820
Open
delphiactual wants to merge 1 commit into
Open
Conversation
…t trickle On the vendors page, item components stream in one vendor at a time, and each update rebuilt every vendor because toVendorGroups depends on the whole vendors response. Cache each built D2Vendor keyed on its own inputs so a single vendor's update only rebuilds that vendor.
delphiactual
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During #11816 and #11819 I noticed a lot of rebuilding with my debug lines, and this a stab a only rebuilding what needs rebuilt
Memoize vendor building per-vendor to avoid full rebuilds on component trickle
On the vendors page, item components stream in one vendor at a time, and each update rebuilt every vendor because toVendorGroups depends on the whole vendors response. Cache each built D2Vendor keyed on its own inputs so a single vendor's update only rebuilds that vendor.