Fix/measurebased relative part zoom#227
Merged
bwbohl merged 3 commits intoJul 6, 2026
Merged
Conversation
bwbohl
force-pushed
the
fix/measurebased-relative-part-zoom
branch
from
3ebfe7c to
8913fe9
Compare
Member
Author
With the above test data, the development version of the frontend should show the following in measureBasedView: 
With the changes of this pull request applied, the area each part gets should be proportional to the space it requires on the score page (screenshot made with #225 applied, too): 
|
Track the tallest slice height within each part and use it to proportionally distribute vertical space between parts instead of dividing equally. This ensures image viewers are sized according to their content rather than splitting space uniformly. The flex value is updated to match the part's representative height, triggering layout recalculation through the owner container's updateLayout method. Closes Edirom#25
Add alignment parameter to showRect to position zones based on viewer count. Implement fitHeight mode to fit zone height to container, ensuring all parts display at common zoom level with full staff visibility. Update vertical space distribution to be proportional to part height rather than equal, maintaining consistent zoom across stacked parts.
Add fitHeight parameter to showRect methods in ImageViewer and
OpenSeaDragonViewer to force zone height to fill container while
left-aligning content. This ensures each part shows its full staff
at common zoom in measure-based view.
Add alignment parameter to OpenSeaDragonViewer.showRect to support
positioning zones horizontally ('left', 'right', 'center') for
proper display in spread layouts.
Update MeasureBasedView to pass fitHeight=true and alignment based
on part position in row for correct multi-part rendering.
bwbohl
force-pushed
the
fix/measurebased-relative-part-zoom
branch
from
8913fe9 to
0556b6d
Compare
Member
Author
|
@hizclick I can reproduce the above difference using develop vs this branch, how is the status for you? |
Contributor
I sent you a DM |
hizclick
approved these changes
Jul 6, 2026
github-project-automation
Bot
moved this from Ready for Review
to Approved
in Edirom Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
Strongly connected to and probably depending on: #225
Fixes measure-based relative part zoom by implementing proportional vertical space distribution and aligned zone display.
Refs #25
closes #25
Important Changes
fitHeightparameter to force zone height to fill container while maintaining full staff visibilityalignmentparameter to support horizontal positioning ('left', 'right', 'center') for zone displayupdateLayoutmethodTypes of changes