Symfony 8 support by 1ed · Pull Request #44 · Elao/ElaoFormTranslationBundle

1ed · 2026-06-14T09:48:10Z

Adds support for Symfony 8 and removes support for unmaintained versions.

…ss dependency

1ed · 2026-06-18T06:38:02Z

Cloud someone merge this and release a new version please? @maximecolin @benji07 @Tom32i

maximecolin

Thanks a lot for the PR 🙏 The migration is clean and consistent (Extension namespace fix, DI configs moved to PHP, composer/CI bumps). A few remarks to address before merging — especially points 1 and 2 in the inline comments; the rest can be follow-ups.

Also: dropping Symfony 7.0–7.3 support (keeping only ^6.4 and ^7.4 LTS + ^8.0) is worth mentioning explicitly in the release notes of the next version. And the README is outdated (Symfony 4.0 badge, AppKernel.php instructions) — pre-existing debt, but this would be a good time to refresh it.

maximecolin · 2026-06-18T08:42:03Z


    /**
-     * @param array<string,mixed> &$vars
+     * @param array<mixed> &$vars


This downgrade from array<string,mixed> to array<mixed> looks like an unnecessary loss of precision: $vars receives $view->vars, which is string-keyed. It also creates an inconsistency with optionEquals() just below, which keeps array<string,mixed>. Could you revert to array<string,mixed>? (and if phpstan was complaining, it's worth understanding why)

$vars passed by reference so the method can change the type, and PropertyAccessor's setValue typed with object|array<mixed> which is looser

I added @param-out array<mixed> $vars which is ok by phpstan.

maximecolin · 2026-06-18T08:42:03Z

@@ -30,7 +30,7 @@ protected function setUp(): void
    /**
     * Get Form Type Extensions
     *
-     * @return array<FormTypeExtensionInterface>
+     * @return array<FormTypeExtensionInterface<Extension\TreeAwareExtension>>


FormTypeExtensionInterface is not generic in Symfony core, so the template parameter <Extension\TreeAwareExtension> is semantically empty (Lint passes, so not fatal, but misleading). The previous array<FormTypeExtensionInterface> was clearer — shall we revert to it?

PhpStan's symfony-extension adds the type:

without it:

maximecolin · 2026-06-18T08:42:03Z

              uses: shivammathur/setup-php@v2
              with:
-                  php-version: '8.3'
+                  php-version: '8.2'


Linting is usually run on the highest supported PHP version. Is this change from 8.3 to 8.2 intentional? (8.3+ would catch recent deprecations better)

Setting PHP_CS_FIXER_IGNORE_ENV environment variable is deprecated and will be removed in 4.0, use unsupportedPhpVersionAllowed config instead. You are running PHP CS Fixer on PHP 8.5.7, but the minimum PHP version supported by your project in composer.json is PHP 8.2. Executing PHP CS Fixer on newer PHP versions may introduce syntax or features not yet available in PHP 8.2, which could cause issues under that version. It is recommended to run PHP CS Fixer on PHP 8.2, to fit your project specifics. If you need help while solving warnings, ask at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/discussions/, we will help you!

maximecolin · 2026-06-18T08:42:03Z

        'simplified_null_return' => false,
        'void_return' => true,
-        'yoda_style' => [],
+        'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],


Disabling yoda_style is a style change unrelated to SF8 support (scope creep). Nothing blocking, but it would ideally belong in a dedicated commit/PR.

It was required by php-cs-fixer to configure it explicitly.

1ed

Thanks for the fast review.

1ed · 2026-06-18T11:46:44Z

              uses: shivammathur/setup-php@v2
              with:
-                  php-version: '8.3'
+                  php-version: '8.2'


Setting PHP_CS_FIXER_IGNORE_ENV environment variable is deprecated and will be removed in 4.0, use unsupportedPhpVersionAllowed config instead. You are running PHP CS Fixer on PHP 8.5.7, but the minimum PHP version supported by your project in composer.json is PHP 8.2. Executing PHP CS Fixer on newer PHP versions may introduce syntax or features not yet available in PHP 8.2, which could cause issues under that version. It is recommended to run PHP CS Fixer on PHP 8.2, to fit your project specifics. If you need help while solving warnings, ask at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/discussions/, we will help you!

1ed · 2026-06-18T11:56:25Z

@@ -30,7 +30,7 @@ protected function setUp(): void
    /**
     * Get Form Type Extensions
     *
-     * @return array<FormTypeExtensionInterface>
+     * @return array<FormTypeExtensionInterface<Extension\TreeAwareExtension>>


PhpStan's symfony-extension adds the type:

without it:

1ed · 2026-06-18T12:28:36Z


    /**
-     * @param array<string,mixed> &$vars
+     * @param array<mixed> &$vars


$vars passed by reference so the method can change the type, and PropertyAccessor's setValue typed with object|array<mixed> which is looser

I added @param-out array<mixed> $vars which is ok by phpstan.

1ed · 2026-06-18T12:28:53Z

        'simplified_null_return' => false,
        'void_return' => true,
-        'yoda_style' => [],
+        'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],


It was required by php-cs-fixer to configure it explicitly.

1ed added 7 commits June 14, 2026 10:29

Update phpunit-bridge

439e1e8

Allow Symfony 8

d921472

Update to supported PHP and Symfony versions

404356e

Update php-cs-fixer config, fix CS

1e6d26e

Update PHPStan and fix errors

5b0111e

Update CI config

b18934f

Convert deprecated xml config to php, remove deprecated extension cla…

2725218

…ss dependency

maximecolin reviewed Jun 18, 2026

View reviewed changes

1ed added 3 commits June 18, 2026 14:23

Keep stronger parameter type while keep phpstan happy

9f5361b

Use latest php version for linting to catch deprecations better

a94a2da

Update README

f71c764

1ed commented Jun 18, 2026

View reviewed changes

1ed force-pushed the symfony-8.x branch from 7b3c9df to da76b50 Compare June 27, 2026 05:04

Update directory structure

9679026

1ed force-pushed the symfony-8.x branch from da76b50 to 9679026 Compare June 27, 2026 05:05

Uh oh!

Conversation

1ed commented Jun 14, 2026

Uh oh!

1ed commented Jun 18, 2026

Uh oh!

maximecolin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maximecolin Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maximecolin Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maximecolin Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maximecolin Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1ed left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maximecolin left a comment •

edited

Loading

maximecolin Jun 18, 2026 •

edited

Loading

maximecolin Jun 18, 2026 •

edited

Loading

maximecolin Jun 18, 2026 •

edited

Loading

maximecolin Jun 18, 2026 •

edited

Loading