Skip to content

reckless: rust rewrite #9239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
daywalker90 wants to merge 2 commits into
base: master
Choose a base branch
from
+6,154 −2,872
Draft

reckless: rust rewrite #9239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fcc54b
cln-rpc: encode amounts as u64, not strings with msat suffix
daywalker90 Jul 2, 2026
e7024ff
reckless: rust rewrite
daywalker90 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 137 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ members = [
"plugins/wss-proxy-plugin",
"plugins/bip353-plugin",
"plugins/currencyrate-plugin",
"plugins/reckless-plugin",
]

[workspace.dependencies]
Expand Down
10 changes: 2 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,7 @@ ALL_NONGEN_SRCFILES := $(ALL_NONGEN_HEADERS) $(ALL_NONGEN_SOURCES)
BIN_PROGRAMS = \
cli/lightning-cli \
lightningd/lightningd \
tools/lightning-hsmtool\
tools/reckless
tools/lightning-hsmtool
PKGLIBEXEC_PROGRAMS = \
lightningd/lightning_channeld \
lightningd/lightning_closingd \
Expand Down Expand Up @@ -872,7 +871,7 @@ clean: obsclean

# See doc/contribute-to-core-lightning/contributor-workflow.md
PYLNS=client proto testing
update-versions: update-pyln-versions update-reckless-version update-dot-version # FIXME: update-doc-examples
update-versions: update-pyln-versions update-dot-version # FIXME: update-doc-examples
@uv lock

update-pyln-versions: $(PYLNS:%=update-pyln-version-%)
Expand Down Expand Up @@ -910,11 +909,6 @@ pyln-build-all: pyln-build pyln-build-bolts pyln-build-grpc-proto pyln-build-wss
update-lock:
uv sync --all-extras --all-groups

update-reckless-version:
@if [ -z "$(NEW_VERSION)" ]; then echo "Set NEW_VERSION!" >&2; exit 1; fi
@echo "Updating tools/reckless to $(NEW_VERSION)"
@$(SED) -i.bak "s/__VERSION__ = '.*'/__VERSION__ = '$(NEW_VERSION)'/" tools/reckless && rm tools/reckless.bak

update-dot-version:
@if [ -z "$(NEW_VERSION)" ]; then echo "Set NEW_VERSION!" >&2; exit 1; fi
echo $(NEW_VERSION) > .version
Expand Down
6 changes: 3 additions & 3 deletions cln-rpc/src/primitives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ impl Serialize for Amount {
where
S: Serializer,
{
serializer.serialize_str(&format!("{}msat", self.msat))
serializer.serialize_u64(self.msat)
}
}

Expand All @@ -637,7 +637,7 @@ impl Serialize for AmountOrAll {
S: Serializer,
{
match self {
AmountOrAll::Amount(a) => serializer.serialize_str(&format!("{}msat", a.msat)),
AmountOrAll::Amount(a) => serializer.serialize_u64(a.msat),
AmountOrAll::All => serializer.serialize_str("all"),
}
}
Expand All @@ -649,7 +649,7 @@ impl Serialize for AmountOrAny {
S: Serializer,
{
match self {
AmountOrAny::Amount(a) => serializer.serialize_str(&format!("{}msat", a.msat)),
AmountOrAny::Amount(a) => serializer.serialize_u64(a.msat),
AmountOrAny::Any => serializer.serialize_str("any"),
}
}
Expand Down
Loading
Loading