[CP Staging] Revert "fix: prevent "Something went wrong" screen flash on failed spend query"#94743
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
mountiny
changed the title
melvin-bot
Bot
requested review from
heyjennahay and
tylerkaraszewski
and removed request for
a team
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mountiny
deleted the
revert-93752-fix/spend-failing-query-error-screen-flash
branch
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3dbd6cd721
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!comingBackOnlineWithNoResults && ((!isFocused && !isMigratedModalDisplayed) || isOffline)) { | ||
| return; |
There was a problem hiding this comment.
When a failed or invalid search leaves searchResults.errors populated, this guard still falls through and calls handleSearch on mount/reconnect. handleSearchAction clears searchRequestResponseStatusCode before the optimistic Search update clears errors, so the render path sees hasErrors with a null status and briefly shows the generic FullPageErrorView instead of the invalid-query message. Please return while hasErrors is true before retrying.
Useful? React with 👍 / 👎.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…ng-query-error-screen-flash [CP Staging] Revert "fix: prevent "Something went wrong" screen flash on failed spend query" (cherry picked from commit c38b401) (cherry-picked to staging by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.21-5 🚀
|
3 participants
Slack context: https://expensify.slack.com/archives/C01GTK53T8Q/p1782520470638799
Reverts #93752
Fixed issues
$ #94742
$ #94782