chore: widen peerDependency to suport v10/v11/v12#714
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the peer dependencies in package.json to support Firebase versions 10, 11, and 12. It is recommended to also update the development dependencies and CI configurations to test against these newer major versions to ensure runtime compatibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }, | ||
| "peerDependencies": { | ||
| "firebase": "^9.0.0 || next", | ||
| "firebase": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || next", |
There was a problem hiding this comment.
Widening the peerDependencies to support Firebase v10, v11, and v12 while keeping devDependencies at ^9.23.0 means the test suite and build processes do not validate compatibility with these newer major versions. Consider updating the devDependencies and CI configurations to run tests against the newly supported major versions to prevent potential runtime compatibility issues for consumers.
Description
Widens peerDependencies for the core firebase package from
^9.0.0 || nextto^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || next