Skip to content

chore: widen peerDependency to suport v10/v11/v12#714

Open
tyler-google-xwf wants to merge 1 commit into
FirebaseExtended:mainfrom
tyler-google-xwf:chore/widen-peer-dependencies
Open

chore: widen peerDependency to suport v10/v11/v12#714
tyler-google-xwf wants to merge 1 commit into
FirebaseExtended:mainfrom
tyler-google-xwf:chore/widen-peer-dependencies

Conversation

@tyler-google-xwf

Copy link
Copy Markdown

Description

Widens peerDependencies for the core firebase package from ^9.0.0 || next to ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || next

@google-cla

google-cla Bot commented Jun 18, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the peer dependencies in package.json to support Firebase versions 10, 11, and 12. It is recommended to also update the development dependencies and CI configurations to test against these newer major versions to ensure runtime compatibility.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread package.json
},
"peerDependencies": {
"firebase": "^9.0.0 || next",
"firebase": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || next",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Widening the peerDependencies to support Firebase v10, v11, and v12 while keeping devDependencies at ^9.23.0 means the test suite and build processes do not validate compatibility with these newer major versions. Consider updating the devDependencies and CI configurations to run tests against the newly supported major versions to prevent potential runtime compatibility issues for consumers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant