Sync main with v0.3.1#701
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
|
| Layer / File(s) | Summary |
|---|---|
Version metadata update CMakeLists.txt, INSTALLATION.md, docs/source/conf.py |
Project version, Spack install instructions, and Sphinx release string all updated from 0.3.0 to 0.3.1. |
Public header install list update phlex/CMakeLists.txt |
Adds driver.hpp to the installed public headers under include/phlex, alongside concurrency.hpp, module.hpp, and source.hpp. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Possibly related PRs
- Framework-R-D/phlex#680: Both PRs touch the same
project(phlex ...)version declaration in CMakeLists.txt. - Framework-R-D/phlex#684: Both PRs bump version metadata in the same trio of files (CMakeLists.txt, docs/source/conf.py, INSTALLATION.md).
- Framework-R-D/phlex#693: Both PRs modify phlex/CMakeLists.txt to install driver.hpp under include/phlex.
Suggested reviewers: beojan, greenc-FNAL, marcpaterno
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly matches the version-sync changes to v0.3.1 and is concise and specific. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
21 fixed, 0 new since branch point (c2ead92) ✅ 21 CodeQL alerts resolved since the branch point
Review the full CodeQL report for details. |
Clang-Tidy Check ResultsFound 5790 issue(s); none are newly introduced by this patch. All issues by check:
See inline comments for details. Comment |
Build system
0.3.0to0.3.1in the top-levelCMakeLists.txt.Packaging / installation
phlex@0.3.1instead ofphlex@0.3.0.driver.hppto the set of public headers installed intoinclude/phlex.Documentation
0.3.1instead of0.3.0.