スポンサーリストを追加#26
Open
masakurapa wants to merge 20 commits into
Open
Conversation
✅ Deploy Preview for unrivaled-empanada-4b1c20 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
ダミー画像でも例を出してくれるとスタイルのレビューなどもできるのですがいかがでしょうか。 |
Contributor
Author
|
@mochi-yu まだ実装途中なので、レビュー投げるときはダミーデータ入れた状態にしますね〜 |
Contributor
|
@masakurapa i18n 対応をスポンサー一覧ページにも取り込んでいます、そちらの都合の良いタイミングで #36 マージしてください 🙇🏻 |
Contributor
Author
|
@mochi-yu ありがとうございます、取り込みました〜!! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
Contributor
|
@masakurapa プッシュしそびれていました、こちらです： b76e0a1 |
Contributor
Author
|
@mochi-yu 全体的に取り込みつつ再調整しました cssの分岐が多くなってきていたため、スポンサー種別毎にcomponentを分離しています preview: https://deploy-preview-30--unrivaled-empanada-4b1c20.netlify.app/ |
This comment was marked as resolved.
This comment was marked as resolved.
mochi-yu
reviewed
Jun 20, 2026
mochi-yu
reviewed
Jun 20, 2026
Contributor
Author
Contributor
|
SP サイズで、ドリンクだけロゴが大きく、シルバー・ランチは padding が余計に入っていそう。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
変更理由
変更内容
レビュワーへの共有事項など