Add native Pegasus and Zephyr plot helpers - #62
Conversation
bernalde
left a comment
There was a problem hiding this comment.
No blocking findings from this review.
The implementation matches issue #61's core request: it adds native DWave.draw_topology and DWave.draw_embedding helpers, routes Pegasus and Zephyr working graphs through D-Wave NetworkX's canonical drawing functions, and keeps embedding overlays on the full calibrated working graph rather than only the used qubits. The metadata/sample-set overloads preserve the DWave.WorkingGraph(QUBOTools.metadata(sampleset)) path, and the README documents the notebook-facing usage.
Blocking issues: none.
Nonblocking issues: none.
Questions: none.
Tests run and outcomes:
DWAVE_API_TOKEN= JULIA_DEPOT_PATH=/home/bernalde/repos/DWave.jl/.julia-depot julia --project=. --startup-file=no test/topology.jlpassed locally againste1f6a662081ff803a14abf236fd1500a941663b1.- GitHub CI is green for Julia 1.10 and Julia 1 on both Ubuntu and Windows.
- Live D-Wave sampler coverage was not exercised locally because
DWAVE_API_TOKENis empty; the existing live-token test path is skipped in that state.
Merge-readiness: the PR is ready for another maintainer's formal approval. This review is posted as COMMENT because the authenticated GitHub account (bernalde) is also the PR author, so GitHub will not accept a formal approval from this account.
Closes #61
Summary
DWave.draw_topologyfor Pegasus, Zephyr,WorkingGraph, sampler metadata, sample sets, and sampler objects.DWave.draw_embeddingfor returned embeddings over the full calibrated Pegasus/Zephyr working graph.axvalues.Tests
DWAVE_API_TOKEN= JULIA_DEPOT_PATH=/home/bernalde/repos/DWave.jl/.julia-depot julia --project=. --startup-file=no test/topology.jlDWAVE_API_TOKEN= JULIA_DEPOT_PATH=/home/bernalde/repos/DWave.jl/.julia-depot julia --project=. --startup-file=no -e 'using Pkg; Pkg.test()'The live
DWave.Optimizerconformance tests were skipped becauseDWAVE_API_TOKENwas empty.Branch Hygiene
mainorigin/main@a35fa52feature/issue-61-topology-plots