Modernize Julia CI and compat floor - #12
Merged
Merged
Conversation
bernalde
commented
May 27, 2026
bernalde
left a comment
Member
Author
There was a problem hiding this comment.
No blocking issues found. I reviewed the PR diff, surrounding compat/test/CI conventions, and documentation surface. The compat floor, dependency bounds, CI matrix, changelog note, and metadata tests are consistent with issue #5, and local plus CI validation are passing.\n\nI attempted to submit this as APPROVE, but GitHub rejected it because the authenticated account is the PR author: Review Can not approve your own pull request. Recording the review as COMMENT for that reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version: '1'.Tests run
julia --startup-file=no -e "import Test, TOML; root = pwd(); project = TOML.parsefile(joinpath(root, \"Project.toml\")); compat = project[\"compat\"]; Test.@testset \"Compatibility metadata\" begin; Test.@test compat[\"julia\"] == \"1.10\"; Test.@test compat[\"QUBODrivers\"] == \"0.4\"; Test.@test compat[\"QUBOTools\"] == \"0.12\"; ci = read(joinpath(root, \".github\", \"workflows\", \"ci.yml\"), String); Test.@test occursin(r\"version:\\s*'1\\.10'\", ci); Test.@test occursin(r\"version:\\s*'1'\", ci); end": passed, 5/5.julia --startup-file=no --project=/tmp/mqlib-issue5-test.MadlRy -e 'using Pkg; Pkg.test()': passed on Julia 1.10.11 from a clean temporary copy without the ignored localManifest.toml; resolved QUBODrivers 0.4.0 and QUBOTools 0.12.0.bash test/native_c_api_smoke.sh: passed; both C ABI smoke binaries returned objective 6.git diff --check: passed.Notes
Manifest.tomlwith development paths would not affect dependency resolution.Closes #5