Add Zenodo citation metadata and release verification - #37
Conversation
bernalde
left a comment
There was a problem hiding this comment.
Initial automated maintainer review
I reviewed head 32e543ad99c0e6730715f4d4718ebe20b2c88741 against issue #36 and the current main tip.
Findings
- Blocking: none
- Nonblocking: 1 inline line-ending cleanup
- Questions: none
Validation
cffconvert --validate --infile CITATION.cff: valid against CFF 1.2.0- Focused citation test: 15/15 passed
- Full local Julia 1.10 package suite: all testsets passed (213 assertions)
- Current-head CI: all four jobs passed
- GitHub-rendered README and both canonical/Camo DOI badges show the concept DOI
- Live Zenodo metadata, archive checksum/content, release tag/commit, upstream MQLib paper DOI, and QUBO.jl article DOI match the PR claims
- Local and GitHub changed-file sets match; the current-base merge probe and combined probe with overlapping PR #33 are conflict-free
Merge readiness
There are no blocking findings. This is a COMMENT review because the authenticated account authored the PR and cannot self-approve. main requires zero approving reviews, so no formal approval gate is enforced; the inline item is a small nonblocking cleanup before final human handoff.
| @@ -1,5 +1,5 @@ | |||
| # MQLib.jl | |||
| [](https://zenodo.org/badge/latestdoi/568213607) | |||
| # MQLib.jl | |||
There was a problem hiding this comment.
Nonblocking: this hunk also converts the unchanged heading from CRLF to LF. The raw README diff is 23 additions/2 deletions, while --ignore-cr-at-eol is 22/1; the mixed-ending file moves from 40 CRLF + 26 LF lines to 38 CRLF + 49 LF lines. Please restore the original CRLF ending on the unchanged heading and retain CRLF on the edited badge line, so this PR changes badge content without incidental line-ending churn.
There was a problem hiding this comment.
Addressed in 4e9d9d9. The heading and edited DOI badge line again use CRLF, preserving the base file's 40 CRLF lines; only the 21 newly added README lines use LF. The raw and --ignore-cr-at-eol PR diffs now both report 22 additions / 1 deletion. The full 213-assertion Julia suite and all four current-head CI jobs pass. I have left this thread unresolved for human confirmation.
|
Addressed the review finding in Validation for this head:
No review items were declined. The second-Zenodo-manager acceptance criterion remains an external human action, and the review thread is intentionally left unresolved for human confirmation. |
Summary
Current Zenodo baseline
v0.7.3DOI: https://doi.org/10.5281/zenodo.209269608ce413f76df2837466fdb6f0178606d75b54127788dba8fa0685f7466f104ce4f0e470c1722fc3616ce6181b8432802cc538b35a811642db432136a949ad601473cdefa3(matches the public record)16f11440-1623-44c9-850c-358a6c72f3c9The public Zenodo API reports
v0.7.3as the latest published version underthe existing concept DOI, with the expected repository, MIT license, creator
list, and one owner entry. The archive contains
Project.tomlversion0.7.3and identifies the release commit above.
Acceptance criteria
10.5281/zenodo.7511329remains authoritative.currently exposes one owner entry, and no authenticated Zenodo credential
is available to verify or add a second manager.
preserve separate attribution to upstream MQLib.
source-commit, checksum, and stewardship drift.
Because the second-manager criterion remains open, this PR uses
Refs #36instead of closing the issue. JuliaQUBO/QUBO.jl#66 remains the ecosystem-level
stewardship and citation-policy tracker.
Validation
uvx --cache-dir /tmp/mqlib-uv-cache --from cffconvert cffconvert --validate --infile CITATION.cff(
cffconvert2.0.0): valid against CFF schema 1.2.0julia +1.10 --project=test -e 'using Test; include("test/citation.jl"); test_citation_metadata()':15/15 passed
julia +1.10 --project -e 'using Pkg; Pkg.test()': all package testsets passed(213 assertions); the existing optional upstream C++ syntax check skipped
because
MQLIB_UPSTREAM_DIRwas not setgit -c core.whitespace=blank-at-eol,blank-at-eof,space-before-tab,cr-at-eol diff --check:passed (the README intentionally retains its existing mixed CRLF/LF endings)
both the canonical Zenodo badge and GitHub Camo badge display
10.5281/zenodo.7511329repository, license, latest-version state, archive checksum, tagged version,
and release commit all match
Branch Hygiene
maindocs/issue-36-zenodo-citation7a56bc4e42c66cc980b6c2e566944d33e53b86eftest/runtests.jl, but its compatibilityassertions and this PR's end-of-file citation-test include are non-adjacent
Refs #36