feat(vscode): add extension project memory controls#11368
Open
johnnyeric wants to merge 1 commit into
Open
Conversation
johnnyeric
changed the title
johnnyeric
changed the base branch from
main
to
johnnyeric/memory-cli-integration
johnnyeric
changed the title
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (14 files)
Fix these issues in Kilo Cloud Previous Review Summaries (6 snapshots, latest commit 7594802)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 7594802)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (28 files)
Fix these issues in Kilo Cloud Previous review (commit bab994d)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (44 files)
Fix these issues in Kilo Cloud Previous review (commit c9e8f1c)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (44 files)
Fix these issues in Kilo Cloud Previous review (commit 0da256c)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (44 files)
Fix these issues in Kilo Cloud Previous review (commit 5722c0a)Status: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (43 files)
Fix these issues in Kilo Cloud Previous review (commit 6b9b312)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (41 files)
Reviewed by gpt-5.4-2026-03-05 · 824,855 tokens Review guidance: REVIEW.md from base branch |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b9b312e71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
johnnyeric
changed the title
johnnyeric
force-pushed
the
johnnyeric/memory-cli-integration
branch
3 times, most recently
from
742338c to
e0a734e
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-vscode-integration
branch
from
6b9b312 to
5722c0a
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-vscode-integration
branch
from
5722c0a to
f45740d
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-cli-integration
branch
from
e0a734e to
9713ad9
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-vscode-integration
branch
from
f45740d to
0da256c
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-cli-integration
branch
from
9713ad9 to
794189b
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-vscode-integration
branch
from
0da256c to
c9e8f1c
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-vscode-integration
branch
from
c9e8f1c to
bab994d
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-vscode-integration
branch
from
bab994d to
7594802
Compare
johnnyeric
force-pushed
the
johnnyeric/memory-vscode-integration
branch
from
7594802 to
89915fa
Compare
| if (message.detail.type === "skipped") return | ||
| if (!message.detail.message) return | ||
| const key = `${message.sessionID ?? ""}:${message.detail.type ?? ""}:${message.detail.message}` | ||
| if (key === last) return |
Contributor
There was a problem hiding this comment.
WARNING: Consecutive identical memory toasts are suppressed
This dedupe key never expires, so repeating the same memory action in the same session drops the second memoryEvent entirely. After the first "Saved project memory" toast, later successful saves with the same message stop surfacing user feedback until some different memory event changes last.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| <div data-slot="task-header-graph-row"> | ||
| <ContextProgress /> | ||
| </div> | ||
| <Show when={memory.status()}> |
Contributor
There was a problem hiding this comment.
WARNING: Task-header memory controls are hidden behind the timeline gate
This new block sits inside the surrounding expanded() && hasTimeline() section, so collapsing the timeline or opening a session that has no rendered timeline removes the memory controls entirely. Since these actions are unrelated to the timeline itself, they should live outside that guard or use their own visibility rule.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No linked issue. Follow-up VS Code integration PR stacked on #11364.
Context
#11355 adds the core project memory package and #11364 wires it into the CLI, TUI, tools, HTTP API, and SDK. This PR adds the VS Code extension surface so project memory can be viewed and controlled from the sidebar and Agent Manager webviews.
The goal is to keep memory storage and CLI behavior in the lower stacked PRs while making the VS Code extension consume the generated SDK/API through extension-owned integration points.
Implementation
Reviewer attention: this PR is intended to be reviewed on top of #11364. Most changes are in VS Code-owned paths; the lower PRs contain the core package, CLI runtime integration, memory tools, HTTP API, and SDK generation.
Screenshots / Video
How to Test
Manual/local verification
Agent verification performed:
git push -u origin johnnyeric/memory-vscode-integrationran the pre-push hook.bun turbo typechecksuccessfully across the workspace.Reviewer test steps
packages/kilo-vscode/, run focused memory-related unit tests, for examplebun run test:unit -- kilo-provider-memory memory-command.Checklist
Depends on #11364.