Skip to content

KRPC-585: Define BSR in Gradle plugin#739

Open
eminasljivic wants to merge 2 commits into
mainfrom
task/KRPC-585
Open

KRPC-585: Define BSR in Gradle plugin#739
eminasljivic wants to merge 2 commits into
mainfrom
task/KRPC-585

Conversation

@eminasljivic

@eminasljivic eminasljivic commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Subsystem
Gradle Plugin, Buf

Problem Description
KRPC-585 & #694: Currently there is no possibility to define BSR modules so that they can be imported in a proto files.

Solution
Add buf.deps property with .module(<module_name>) and lockFile. If modules were defined then the new task BufLockTask will run and either generate a buf.lock file with buf dep update or copy the provided lock file.

In addition instead of using workingDir as an input the three generated files buf.yaml, buf.gen.yaml and buf.lock are now marked as input. This is due to the fact that buf dep update generates files in the directory and would cause the BufGenerateTask to run every time even though the relevant files didn't change.

@eminasljivic
eminasljivic requested a review from Mr3zee July 1, 2026 08:35
@eminasljivic eminasljivic added the feature New feature or request label Jul 1, 2026
@eminasljivic eminasljivic changed the title Task/krpc 585 KRPC-585: Define BSR in Gradle plugin Jul 1, 2026
@Mr3zee

Mr3zee commented Jul 1, 2026

Copy link
Copy Markdown
Member

Hey, nice work!

Two things I notice before I do an actual review:

  • Please add free BSR account token to the CI, otherwise we might run out of free no account quota
  • I see that you can't add deps per source set. Please address that and add comprehensive tests (deps should be transitive between source sets, additive in android variants case)

@Mr3zee Mr3zee closed this Jul 7, 2026
@Mr3zee
Mr3zee deleted the task/KRPC-585 branch July 7, 2026 13:05
@eminasljivic
eminasljivic restored the task/KRPC-585 branch July 9, 2026 12:01
@eminasljivic eminasljivic reopened this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants