KRPC-585: Define BSR in Gradle plugin#739
Open
eminasljivic wants to merge 2 commits into
Open
Conversation
Member
|
Hey, nice work! Two things I notice before I do an actual review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsystem
Gradle Plugin, Buf
Problem Description
KRPC-585 & #694: Currently there is no possibility to define BSR modules so that they can be imported in a proto files.
Solution
Add
buf.depsproperty with.module(<module_name>)andlockFile. If modules were defined then the new taskBufLockTaskwill run and either generate abuf.lockfile withbuf dep updateor copy the provided lock file.In addition instead of using
workingDiras an input the three generated filesbuf.yaml,buf.gen.yamlandbuf.lockare now marked as input. This is due to the fact thatbuf dep updategenerates files in the directory and would cause theBufGenerateTaskto run every time even though the relevant files didn't change.