feat(video): add support for legacy MPEG-2 and H.263+ encoders#5194
feat(video): add support for legacy MPEG-2 and H.263+ encoders#5194ReenigneArcher wants to merge 1 commit into
Quality Gate failed
Failed conditions
14 New issues
14 New Code Smells (required ≤ 0)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
Annotations
Check warning on line 15 in tests/unit/test_video.cpp
sonarqubecloud / SonarCloud Code Analysis
Do not use the constructor's initializer list for data member "h263p_mode". Use the in-class initializer instead.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X2&open=AZ5gBTo6OcYDVOXjq4X2&pullRequest=5194
Check failure on line 1263 in src/video.cpp
sonarqubecloud / SonarCloud Code Analysis
Global variables should be const.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTgCOcYDVOXjq4Xt&open=AZ5gBTgCOcYDVOXjq4Xt&pullRequest=5194
Check warning on line 13 in tests/unit/test_video.cpp
sonarqubecloud / SonarCloud Code Analysis
Do not use the constructor's initializer list for data member "av1_mode". Use the in-class initializer instead.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X3&open=AZ5gBTo6OcYDVOXjq4X3&pullRequest=5194
Check failure on line 363 in src/video.h
sonarqubecloud / SonarCloud Code Analysis
Global variables should be const.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xx&open=AZ5gBTnROcYDVOXjq4Xx&pullRequest=5194
Check failure on line 10 in tests/unit/test_video.cpp
sonarqubecloud / SonarCloud Code Analysis
Customize this struct's copy constructor to participate in resource management. Customize or delete its copy assignment operator. Also consider whether move operations should be customized.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X5&open=AZ5gBTo6OcYDVOXjq4X5&pullRequest=5194
Check warning on line 12 in tests/unit/test_video.cpp
sonarqubecloud / SonarCloud Code Analysis
Do not use the constructor's initializer list for data member "hevc_mode". Use the in-class initializer instead.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X4&open=AZ5gBTo6OcYDVOXjq4X4&pullRequest=5194
Check failure on line 1259 in src/video.cpp
sonarqubecloud / SonarCloud Code Analysis
Global pointers should be const at every level.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTgCOcYDVOXjq4Xr&open=AZ5gBTgCOcYDVOXjq4Xr&pullRequest=5194
Check warning on line 2863 in src/video.cpp
sonarqubecloud / SonarCloud Code Analysis
This lambda has 23 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTgCOcYDVOXjq4Xu&open=AZ5gBTgCOcYDVOXjq4Xu&pullRequest=5194
Check failure on line 1262 in src/video.cpp
sonarqubecloud / SonarCloud Code Analysis
Global variables should be const.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTgCOcYDVOXjq4Xs&open=AZ5gBTgCOcYDVOXjq4Xs&pullRequest=5194
Check warning on line 24 in src/video.h
sonarqubecloud / SonarCloud Code Analysis
Replace this "enum" with "enum class".
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xv&open=AZ5gBTnROcYDVOXjq4Xv&pullRequest=5194
Check failure on line 364 in src/video.h
sonarqubecloud / SonarCloud Code Analysis
Global variables should be const.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xy&open=AZ5gBTnROcYDVOXjq4Xy&pullRequest=5194
Check warning on line 14 in tests/unit/test_video.cpp
sonarqubecloud / SonarCloud Code Analysis
Do not use the constructor's initializer list for data member "mpeg2_mode". Use the in-class initializer instead.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTo6OcYDVOXjq4X1&open=AZ5gBTo6OcYDVOXjq4X1&pullRequest=5194
Check failure on line 365 in src/video.h
sonarqubecloud / SonarCloud Code Analysis
Global variables should be const.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xz&open=AZ5gBTnROcYDVOXjq4Xz&pullRequest=5194
Check failure on line 362 in src/video.h
sonarqubecloud / SonarCloud Code Analysis
Global variables should be const.
See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ5gBTnROcYDVOXjq4Xw&open=AZ5gBTnROcYDVOXjq4Xw&pullRequest=5194