fix(pr-review): flag legacy skill metadata#108
Draft
jordelmir wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improves the PR review skill validator so malformed
SKILL.mdfiles withname:anddescription:outside YAML frontmatter get a specific actionable error instead of the generic missing-frontmatter message.It also tightens frontmatter extraction so the opening and closing
---markers must be standalone marker lines.Why
MiniMax/Mavis skill loaders depend on YAML frontmatter metadata. A common legacy shape looks like:
# Skill: Example name: example description: Example trigger text.That format is easy to miss during review, but downstream agents can index those skills with empty descriptions or stale metadata. This validator change catches the exact pattern and tells contributors how to fix it.
Validation
python3 .claude/skills/pr-review/scripts/validate_skills.py --path <tmp legacy fixture>fails with the new targeted message.python3 .claude/skills/pr-review/scripts/validate_skills.pystill reports the existing baseline failure inskills/minimax-multimodal-toolkit(name: mmx-clidoes not match the directory). I verified the same failure exists onorigin/mainbefore this patch.