fix(links): repair broken internal links and JSON-LD logo - #433
Merged
Conversation
The broken-links CI job was failing on three classes of dead links: - Translation pages still pointed practice links at the old internal /minimumcd/<slug>/ paths, which 404 since those pages moved to beyond.minimumcd.org. Repointed all 10 translation files to the canonical beyond.minimumcd.org/docs/reference/practices/ URLs, matching the English _index.md. - The Organization JSON-LD logo used an absolute BaseURL path to /icons/logo.svg, which is published from assets/ via Hugo's pipeline (never as a static file) so the absolute URL 404'd. Switched to the asset's RelPermalink so it resolves to the actually-published path. - Doug Barrett's signatory contact https://dkb.nz/ serves an invalid TLS cert (custom domain on GitLab Pages, *.gitlab.io cert) and is unreachable for all visitors. Added it to the linkinator skip list alongside the other personal-contact domains. Link check now passes clean (0 broken links). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for minimumcd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The Netlify deploy preview failed at the build stage (exit code 2) because HUGO_VERSION was pinned to 0.151.2, which predates the recent docsy theme upgrade and can no longer build the site. GitHub Actions CI passes because it uses hugo-version: latest. Align Netlify to the latest releases that build cleanly locally: Hugo 0.162.1, Go 1.26.4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The broken links test job in CI was failing (e.g. run 26839490398) — 168 broken links detected. Three root causes:
What changed
/minimumcd/<slug>/paths, which now 404 since those pages moved tobeyond.minimumcd.org. Repointed them to the canonicalbeyond.minimumcd.org/docs/reference/practices/…URLs, matching the English_index.md(verified each target returns 200):single-path-to-production,deterministic→deterministic-pipeline,deployable→definition-of-deployable,immutable→immutable-artifacts,production-like-test-environment→production-like-environments,rollback,application-configuration,trunk-based-development,continuous-integration.layouts/partials/hooks/head-end.htmlemitted the logo as an absolute{{ .Site.BaseURL }}icons/logo.svg, but that file is published fromassets/via Hugo's asset pipeline (never as a static/icons/logo.svg), so the absolute URL 404'd. Switched to the asset'sRelPermalinkso it resolves to the actually-published path and is validated locally.dkb.nzsignatory contact. Doug Barrett's contacthttps://dkb.nz/serves an invalid TLS cert (custom domain on GitLab Pages, presenting a*.gitlab.iocert) and is unreachable for all visitors. Added it to the linkinator skip list alongside the other personal-contact domains (linkedin/youtube/twitter/github).Validation
Dead-link validation already exists via
pnpm run test:links(linkinator) and runs in CI. Locally, after these fixes:pnpm test(markdownlint) — passeshugo --minify— builds cleanlinkinator ./public— ✓ 0 broken links (135 scanned)🤖 Generated with Claude Code